On 08/07/2016 11:07 AM, Michael Biebl wrote:
> Source: liblognorm
> Version: 1.1.2-1.1
> Severity: important
> Tags: patch
>
> Hi Pierre!
>
> The latest rsyslog version in Debian is quite outdated. The reason is,
> that newer versions require libfastjson instead of json-c.
>
> I've already packages libfastjson, and it is available in unstable and
> testing [1].
> Before I can switch rsyslog over to use libfastjson, I need a newer
> version of liblognorm as well, which as been compiled against
> libfastjson. I've been working with rsyslog/liblognorm upstream and the
> latest versio 2.0.1 should be ok.
> Please consider packaging that version. To test newer rsyslog versions,
> I've already updated liblognorm locally and pushed my work to [2]. Feel
> free to base your update on that.
> Since the library had a soname bump which means going through the NEW
> queue, I decided to introduce a new binary package for the lognormalizer
> tool to fix #753510.
> The git log should be self-explanatory. If you have any questions,
> please don't hesitate to ask.
>
> As the package didn't have a public (Git) repository, I've created a
> private on based on the last NMU using git-buildpackage [2].
>
Hi Michael,
I'm working on the packaging of version 2.0.1, it should be ready soon.
I had a look at your repository, it seems you only bumped dependencies,
but I got new errors with gcc 6:
samp.c: In function ‘ln_sampChkRunawayRule’:
samp.c:937:4: error: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Werror=unused-result]
(void)fread(buf, sizeof(char), 1, repo); /* skip '\n' */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]
While it will be easy to fix, I'm surprised you did not had the same.
I also had to drop 01-fix-pkgconfig.patch, conflicting, and I think not
necessary now.
The new binary package is a good idea, I will indeed merge it.
When the upload is ready, I will push my repository on alioth to ease
collaborative work.
Thanks for your patches.
Regards,
Pierre
