Hi

Am 08.08.2016 um 22:04 schrieb Pierre Chifflier:
> On 08/07/2016 11:07 AM, Michael Biebl wrote:
> Hi Michael,
> 
> I'm working on the packaging of version 2.0.1, it should be ready soon.
> I had a look at your repository, it seems you only bumped dependencies,

No, I did not only bump the dependencies.
https://anonscm.debian.org/cgit/users/biebl/liblognorm.git/log/
has quite a few more changes

> but I got new errors with gcc 6:
> 
> samp.c: In function ‘ln_sampChkRunawayRule’:
> samp.c:937:4: error: ignoring return value of ‘fread’, declared with
> attribute warn_unused_result [-Werror=unused-result]
>     (void)fread(buf, sizeof(char), 1, repo); /* skip '\n' */
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]
> 
> While it will be easy to fix, I'm surprised you did not had the same.

You've enabled Werror. Probably because you've built directly inside the
git directory. In this case, --enable-compile-warnings= defaults to
error. I use git buildpackage, which uses a git export in a separate
build directory, so I don't run into this problem.

You can explicitly set --enable-compile-warnings=yes in debian/rules to
avoid that. (Or disable compiler warnings completely via
--enable-compile-warnings=no, but I wouldn't recommend that)

> I also had to drop 01-fix-pkgconfig.patch, conflicting, and I think not
> necessary now.

Yeah, this was fixed upstream
https://github.com/rsyslog/liblognorm/pull/215

> The new binary package is a good idea, I will indeed merge it.
> 
> When the upload is ready, I will push my repository on alioth to ease
> collaborative work.

This would be great.

> Thanks for your patches.

Regards,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to