¡Hola Guido! El 2016-08-19 a las 09:43 +0200, Guido Günther escribió:
Thanks a lot for the patches - this makes sens (and I think we discussed it at debconf)!
Yes, I also plan to work on improving the import of dep-3 patches headers, when time allows it.
On Thu, Aug 18, 2016 at 01:40:35PM +0200, Maximiliano Curia wrote:Currently patch queue assumes that the upstream branch is merged in the Debian branch. But, at the same time having them unmerged is a valid setup for buildpackage, even more, the pq support works assuming that the upstream
You mean the rpm-pq support?
Right.
I'm glad to apply this. Two things: could you rebase against current master which has had some changes (but not many in pq). And is there a chance you add a testcase in tests/component/deb/test_pq.py ? This would be a new component test but it would be perfectly fine to only test the new functionality.
The patches were prepared against master, I've added some test, (adding a class to the existing tests/13_test_gbp_pq.py, sorry about that) I might be able to migrate it to a component test when I understand to do this kind of tests in them.
In case you have a repo I can pull from therei is no need to attach all the patches to the bts.
I've pushed my changes to a github fork: https://github.com/maxyz/git-buildpackage/tree/pq_unmerged_upstream And created a pull request for it: https://github.com/agx/git-buildpackage/pull/27 Happy hacking, -- "When explaining a command, or language feature, or hardware widget, first describe the problem it is designed to solve." -- David Martin Saludos /\/\ /\ >< `/
signature.asc
Description: Digital signature
