Package: irker Version: 2.18+dfsg-1 Severity: normal Tags: patch pending [Replace XX with correct value] Dear maintainer,
I've prepared an NMU for irker (versioned as 2.18+dfsg-1.1) and uploaded it to DELAYED/10. Please feel free to tell me if I should delay it longer. Regards.
diff -Nru irker-2.18+dfsg/debian/changelog irker-2.18+dfsg/debian/changelog --- irker-2.18+dfsg/debian/changelog 2016-06-18 04:54:48.000000000 -0400 +++ irker-2.18+dfsg/debian/changelog 2016-09-12 12:09:50.000000000 -0400 @@ -1,3 +1,12 @@ +irker (2.18+dfsg-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * new patches to the .service file: + * run daemon as the irker used (Closes: #832758) + * properly import environment from /etc/defaults (Closes: #832322) + + -- Antoine Beaupré <anar...@debian.org> Mon, 12 Sep 2016 11:59:26 -0400 + irker (2.18+dfsg-1) unstable; urgency=low * Update to latest upstream release. diff -Nru irker-2.18+dfsg/debian/patches/0008-user-service.patch irker-2.18+dfsg/debian/patches/0008-user-service.patch --- irker-2.18+dfsg/debian/patches/0008-user-service.patch 1969-12-31 19:00:00.000000000 -0500 +++ irker-2.18+dfsg/debian/patches/0008-user-service.patch 2016-09-12 12:04:51.000000000 -0400 @@ -0,0 +1,28 @@ +commit 1980b7cb4239463b581579cc39480774d3e2d2fe +Author: Antoine Beaupré <anar...@debian.org> +Date: Mon Sep 12 12:01:44 2016 -0400 + + run daemon as the irker user (Close: #832758) + + this is an improvement upon the default .service file. it requires a + irker user to be created, something which is automatically handled by + the debian package, but should be handled by other distributions when + deploying the .service file. + + there are obvious dangers in running irkerd as root: a compromise + would be catastrophic, and since it runs on public servers that are + traditionnally pretty hostile (IRC), it seems critical that rights of + the daemon be limited. + +diff --git a/irkerd.service b/irkerd.service +index d19378b..82f39b0 100644 +--- a/irkerd.service ++++ b/irkerd.service +@@ -7,6 +7,7 @@ Requires=network.target + + [Service] + ExecStart=/usr/bin/irkerd ++User=irker + + [Install] + WantedBy=multi-user.target diff -Nru irker-2.18+dfsg/debian/patches/0009-env-service.patch irker-2.18+dfsg/debian/patches/0009-env-service.patch --- irker-2.18+dfsg/debian/patches/0009-env-service.patch 1969-12-31 19:00:00.000000000 -0500 +++ irker-2.18+dfsg/debian/patches/0009-env-service.patch 2016-09-12 12:08:44.000000000 -0400 @@ -0,0 +1,14 @@ +diff --git a/irkerd.service b/irkerd.service +index 82f39b0..f4cd45b 100644 +--- a/irkerd.service ++++ b/irkerd.service +@@ -6,7 +6,8 @@ Description=irker daemon + Requires=network.target + + [Service] +-ExecStart=/usr/bin/irkerd ++EnvironmentFile=-/etc/default/irker ++ExecStart=/usr/bin/irkerd $IRKER_OPTIONS + User=irker + + [Install] diff -Nru irker-2.18+dfsg/debian/patches/series irker-2.18+dfsg/debian/patches/series --- irker-2.18+dfsg/debian/patches/series 2016-03-17 18:42:26.000000000 -0400 +++ irker-2.18+dfsg/debian/patches/series 2016-09-12 12:08:55.000000000 -0400 @@ -2,3 +2,5 @@ 0005-author-name.patch 0006-alias-service.patch 0007-irkerhook-git.patch +0008-user-service.patch +0009-env-service.patch
signature.asc
Description: Digital signature
