On Sat, 17 Sep 2016 21:27:33 +0300, Niko Tyni wrote:

> > From starting at t/daemon.t my guess is that we're seeing a race
> > condition or some other timing issue here -- the daemon writes to a
> > log file and the test reads the logfile, and in one case the log
> > message doesn't seem to be there (yet?). At least that's my current
> > guess.
> Indeed, the daemon first opens the file for writing and only then writes
> it (see the logger script at top of daemon.t), while the test waits for
> existence (-e) and then proceeds to check the file contents.
> I think the attached patch should fix it. I was able to reproduce
> the issue sporadically without the patch, and couldn't get it to
> happen after applying this.

Great, thanks.
> > I'm tempted to mark this log-reading test as TODO since this seems a
> > bit fragile.
> No objections, but let's try the patch first?

Sure, a fix is always better than a workaround :)

Patch forwarded upstream, package uploaded.


 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Tony Joe White: Goin' Down Rockin'

Attachment: signature.asc
Description: Digital Signature

Reply via email to