Package: qconf
Version: 2.1-1
Severity: important

Hi Boris,

with 2.1-1, you "backported remove-bashism-from-configure.patch" to fix
bashisms in the configure script contained in the qconf package.

While this fixes the build of qconf itself, qconf still generates
configure scripts containing these bashisms for other packages.

Therefore, it's necessary to also backport the following patch:
https://github.com/psi-plus/qconf/commit/f84f570dd760b1641dfd8d6eb12d34f48bf90af6

----------------------------------------------------------------------
commit f84f570dd760b1641dfd8d6eb12d34f48bf90af6
Author: Rion <rion...@gmail.com>
Date:   Tue May 31 20:10:40 2016 +0600

    Fixed bashism (thanks Pull #9)

diff --git a/src/qconf.cpp b/src/qconf.cpp
index 93f9098..ce6a4f9 100644
--- a/src/qconf.cpp
+++ b/src/qconf.cpp
@@ -767,7 +767,7 @@ private:
        {
                QString str =
                "if [ -z \"$QC_QTSELECT\" ]; then\n"
-               "       QC_QTSELECT=\"${QT_SELECT/qt/}\"\n"
+               "       QC_QTSELECT=\"$(echo $QT_SELECT | tr -d \"qt\")\"\n"
                "fi\n"
                "\n"
                "if [ ! -z \"$QC_QTSELECT\" ]; then\n"
----------------------------------------------------------------------

This is likely the cause for bugs 841627 and 841557 in psi and psi-plus
packages. ("./configure: Bad substitution")

Best regards,
Jan

PS: At least for the psi package, there are more build failures with
qconf 2.1, probably because of some incompatibilities between qconf 1.5
and qconf 2.1. Didn't try with qconf 2.0, yet.

Reply via email to