Hi!

Sorry for the delay, I was offline during the last weeks.

On 2017-06-15 22:15+0200, Gianfranco Costamagna wrote:
> Hello,
> 
>>    gbp clone --pristine-tar 
>> https://anonscm.debian.org/git/pkg-go/packages/golang-go-ini-ini.git
> 
> lets review (the mentors link)
> +golang-github-go-ini-ini (1.27.0-1) experimental; urgency=medium
> +
> +  * New upstream version 1.27.0
> +  * update Standards-Version and debhelper version
> +  * add myself to the uploaders
> +  * use https in the Vcs-Browser field
> +
> + -- Félix Sipma <felix+deb...@gueux.org>  Tue, 16 May 2017 16:22:10 +0200
> +
> +golang-github-go-ini-ini (1.8.6-3) unstable; urgency=medium
> +
> +  * Team upload.
> +  * Use a secure transport for the Vcs-Git and Vcs-Browser URL
> +
> + -- Paul Tagliamonte <paul...@debian.org>  Wed, 29 Jun 2016 20:21:03 -0400
> +
> 
> please merge the two changelog entries together

done

> please ask your comaintainers (in cc), if you can add yourself in uploaders 
> list

will do

>>    2017/05/16 18:21:46 FAILED: grafana_2.6.0+dfsg-3 (see 
>> buildlogs/grafana_2.6.0+dfsg-3)
>>    2017/05/16 18:21:46 FAILED: nomad_0.4.0+dfsg-1 (see 
>> buildlogs/nomad_0.4.0+dfsg-1)
>>    2017/05/16 18:21:46 FAILED: packer_0.10.2+dfsg-5 (see 
>> buildlogs/packer_0.10.2+dfsg-5)
>>    2017/05/16 18:21:46 FAILED: goiardi_0.11.4-1 (see 
>> buildlogs/goiardi_0.11.4-1)
>> 
>> grafana and nomad fails for unrelated reasons (see attached logs)
>> 
>> I don't get why goiardi and packer fail.
> 
> this should be sorted out before uploading in unstable, please ask upstream 
> or relative maintainers
> and fix this

not done yet... I also changed the target from experimental to unstable.

>> If the person who sponsors the upload could also give me upload permissions 
>> for
>> this package, that would be great!
> 
> after updating it, prod me if I forget :)
> 
> review:
> 
> +Vcs-Browser: 
> https://anonscm.debian.org/gitweb/?p=pkg-go/packages/golang-github-go-ini-ini.git;a=summary
> 
> please use cgit

done

> +         ${misc:Depends},
> +         golang-go
> 
> not mentioned in changelog

I just changed the indentation, this was already there :-).

> +version=3
> + https://github.com/go-ini/ini/releases \
> + .*/v?(\d[\d\.]*)\.tar\.gz
> 
> please mention in changelog

I have not done anything to this...

> and then we should be good :)
> 
> G.

Thanks for your review! Other people have expressed interest in getting an
updated restic in sid, so I hope to get help to fix the build failures... I've
uploaded the new package to mentors.

Attachment: signature.asc
Description: PGP signature

Reply via email to