On Fri, Jul 28, 2017 at 12:52:11AM +0200, Svante Signell wrote:

> ifupdown FTBFS due to a trivial omission to install <stdio.h> on both
> Hurd and kFreeBSD in files archhurd.c and archkfreebsd.c, respectively.

Thanks, I applied your patches.

> Additionally the function expand_matches() needs some fixes to cope
> with Hurd naming network interfaces e.g. /dev/eth0 instead of eth0.

Oh shit. And why is lo without /dev/? Gah! Maybe the best thing is to
find an alternative character for patterns on Hurd... backslash?

> I think we should continue the effort to remove global variables
> further, and provide test cases for the new functionality. Next would
> be a test for the rename option as well as ifquery. I'm pretty sure
> ifquery can be supported for Hurd too. For kFreeBSD I'm more unsure, I
> just checked that the build was OK with the proposed patch.

I can check it in a VM, although I'm not a user of kFreeBSD myself.

-- 
Met vriendelijke groet / with kind regards,
      Guus Sliepen <[email protected]>

Attachment: signature.asc
Description: PGP signature

Reply via email to