On Fri, Nov 10, 2017 at 08:25:59PM +0100, Alberto Garcia wrote: > Both those flags (--no-keep-memory and --no-relax) plus the -g1 that > you're changing in your patch were added because the build was failing > (not enough memory, at least in the 1st and the 3rd case).
Thanks for your attention to detail. Yes, at least --no-keep-memory should keep being conditional of the build architecture. That part of my patch is wrong then. > If the build machine is able to compile webkit without those flags > then there's no need to add them, so if I'm understanding it right it > doesn't depend on the target architecture but on the machine where > you're doing the build. For --no-relax, the question is harder as it influences the object file generated. Given your reasoning though, maybe checking build is still better. > For the -g1 case we probably want to do it depending on the target > architecture anyway, but for the --no-keep-memory case I don't see > why. I stand corrected. > And now that we're at it, I'm not sure if --no-relax is even necessary > anymore. This was added for alpha in 2008 to work around a binutils > bug, which I guess has been already fixed ? It would be nice to test > that, but I don't have access to an alpha machine. You could try cross building from amd64. ;) Helmut