Ivan Vučica wrote:
> Also malloc(...)+1 should be malloc(...+1).

That's right, it is the latter in my patch.

> Also strncpy() IIRC doesn’t add a nul terminator.

Correct, it is added with a special assignment after the loop, so
this is already handled.

> How about calloc() to also zero the memory out, or at least
> newpath[newblen] = 0? (Or the equivalent in the new patch.)

Perhaps this is a good idea.

> Alternatively just use ObjC to manipulate strings of UTF8 text.

The usual approach in fixing arch-specific bugs, at least in Debian,
is to try not to diverge much from the existing code.  Of course ObjC
can be used, probably even SQLClient.

Reply via email to