Hi Adam, On Tue, Jan 16, 2018 at 09:25:19PM +0100, Adam Borowski wrote: > Package: btrfsmaintenance > Version: 0.3.1-17-gf7d61e3-1~exp1 > Severity: important > > Hi! > The package, as currently provided, is non-functional without manual actions > on non-systemd systems.
This is intended, and the packaging on the master branch of the Debian package also requires manual activation for systemd systems. > During installation, there's an error: > /usr/bin/deb-systemd-helper: error: unable to read > btrfsmaintenance-refresh.path Oh my, that was sloppy work on my part. Thank you for keeping me accountable! I'll fix this for the next upload. > then the cron jobs are not installed by default. According to README.Debian: > > # # or run the script directly > # /usr/share/btrfsmaintenance/btrfsmaintenance-refresh-cron.sh > # > # Running the refresh-cron script is required on Debian or Debian-like > # systems that do not use systemd. > > so fixing this should be a matter of just running this in appropriate places > (such as postinst; or, to be safe, during boot as well). I agree that it should be run during boot (once manually enabled), because this is what the upstream timer that calls btrfsmaintenance-refresh-cron.sh does. At some point it might be cool to non-default priority dpkg-configure knob to make this easier to enable. > (I haven't actually tested the scripts yet -- having manually written ones > everywhere.) > Do you have anything that would improve upstream btrfsmaintenance? I believe now might be a good time to contribute, because a lot of work is being done in preparation for the next release. > Also, I don't see what's the point in using .service/.timer at all, as they > use no systemd-specific features, so this complicates maintenance for no gain. > Honestly I'm neutral on the sysvinit vs systemd vs alternatives debate, and yes I'm also uncomfortable with some of systemd's "replacements" for existing functionality; however, I think this is a gain: https://github.com/kdave/btrfsmaintenance/issues/42 (power-state aware init of jobs that work in a cross-distribution way, plus hopefully support for deferred scheduling). Of course, this is also possible with anacron, a power-state check in the scripts, plus something in /var to note the last time maintenance was done. ;-) Cheers, Nicholas
signature.asc
Description: PGP signature
