Quoting Magnus Holmgren <[EMAIL PROTECTED]>: > Turbo Fredriksson skrev: >> Quoting Magnus Holmgren <[EMAIL PROTECTED]>: >>> >>>The extra lines containing just a "#" before the "#!NO_MODULE" lines in >>>modules/throttling/throttlelib.pike and >>>modules/icecast/pl_common.pike, which are introduced by >>>patches/001_pike_path, cause compilation errors. Is there >>>any reason for those lines to be there? >> >> So that roxen will recognize the fact that they are modules. > > Wouldn't it simpler to just remove the "#!NO_MODULE" then? What was the > reason for putting in those lines in the upstream source?
No, because there are checks in place for this string. Can't remember exactly where I found it (I found it when packaging Roxen3 years ago), but at the time, Roxen didn't see that the file(s) in question was modules without that line. If you unpack the pristine code, you'll see that there are files that have this line as well. I just added some more files to this 'list'. > I don't think they are Roxen modules; they are just code common to the > modules. For instance, they don't have the module_type, module_name and > module_doc constants. Hmm. Okey, that IS a 'problem' though. All of them? -- colonel fissionable killed attack kibo toluene North Korea Soviet SEAL Team 6 KGB ammonium BATF Khaddafi pits FBI [See http://www.aclu.org/echelonwatch/index.html for more about this] [Or http://www.europarl.eu.int/tempcom/echelon/pdf/rapport_echelon_en.pdf] If neither of these works, try http://www.aclu.org and search for echelon. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
