Hi Niels, On Tue, Jan 01, 2019 at 09:51:26PM +0000, Niels Thykier wrote: > Dear maintainer,
> I've prepared an NMU for pam (versioned as 1.1.8-3.9) and > uploaded it to DELAYED/5. Please feel free to tell me if I > should delay it longer. > Regards. > diff -u pam-1.1.8/debian/changelog pam-1.1.8/debian/changelog > --- pam-1.1.8/debian/changelog > +++ pam-1.1.8/debian/changelog > @@ -1,3 +1,20 @@ > +pam (1.1.8-3.9) unstable; urgency=medium > + > + * Non-maintainer upload. > + > + [ Niels Thykier ] > + * Enable dh_dwz to reduce the size of the dbgsym files. What is the NMU rationale for this change? There does not appear to be a corresponding bug report, and there is certainly not one referenced in the changelog. This looks likely to cause build failures in some circumstances, given the lack of corresponding build-dependency changes. I am not enthusiastic about pam being opted in to non-default debhelper settings via NMU. > + * Remove Roger Leigh from uploaders as he has retired from > + Debian. (Was mentioned in the last upload but not actually > + done). > + * Pass --parallel to dh to enable building pam with multiple cores. > + [ Helmut Grohne ] > + * Convert DEB_BUILD_PROFILE=stage1 to DEB_BUILD_PROFILES=pkg.pam.noaudit. > + (Closes: #907492) Though I had not followed up on the bug report, I disagree with this change and thus nack this NMU. I do not agree that it is preferable to use an explicit 'pkg.pam.noaudit' profile name instead of 'stage1'. The pam package was an early adopter of build profiles precisely for the purpose of archive bootstrapping, and for archive bootstrapping what is interesting is NOT that the package is built without audit, what is interesting is that it is a bootstrap build. The fact that audit is the specific package being excluded is a point-in-time implementation detail that should NOT be exposed. Please withdraw this NMU. > + -- Niels Thykier <[email protected]> Tue, 01 Jan 2019 21:50:19 +0000 > + > pam (1.1.8-3.8) unstable; urgency=medium > > * Non-maintainer upload. > @@ -5,7 +22,7 @@ > chgrp in debian/rules. > * Update pam-auth-update to detect write errors and properly > fail when that happens. (Closes: #880501) > - * Remove Roger Leigh from uploaders as he has restired from > + * Remove Roger Leigh from uploaders as he has retired from > Debian. (Closes: #869348) > * Reduce priority of libpam0g to optional. > * Rebuild with a recent version of dpkg-source, which ensures > diff -u pam-1.1.8/debian/control pam-1.1.8/debian/control > --- pam-1.1.8/debian/control > +++ pam-1.1.8/debian/control > @@ -1,10 +1,10 @@ > Source: pam > Section: libs > Priority: optional > -Uploaders: Sam Hartman <[email protected]>, Roger Leigh <[email protected]> > +Uploaders: Sam Hartman <[email protected]> > Maintainer: Steve Langasek <[email protected]> > Standards-Version: 3.9.8 > -Build-Depends: libcrack2-dev (>= 2.8), bzip2, debhelper (>= 9), quilt (>= > 0.48-1), flex, libdb-dev, libselinux1-dev [linux-any], po-debconf, > dh-autoreconf, autopoint, libaudit-dev [linux-any], pkg-config, libfl-dev, > libfl-dev:native, docbook-xsl, docbook-xml, xsltproc, libxml2-utils, w3m > +Build-Depends: libcrack2-dev (>= 2.8), bzip2, debhelper (>= 9), quilt (>= > 0.48-1), flex, libdb-dev, libselinux1-dev [linux-any], po-debconf, > dh-autoreconf, autopoint, libaudit-dev [linux-any] <!pkg.pam.noaudit>, > pkg-config, libfl-dev, libfl-dev:native, docbook-xsl, docbook-xml, xsltproc, > libxml2-utils, w3m > Build-Conflicts-Indep: fop > Build-Conflicts: libdb4.2-dev, libxcrypt-dev > Vcs-Bzr: https://alioth.debian.org/scm/loggerhead/pkg-pam/debian/sid > diff -u pam-1.1.8/debian/rules pam-1.1.8/debian/rules > --- pam-1.1.8/debian/rules > +++ pam-1.1.8/debian/rules > @@ -18,10 +18,10 @@ > dl = $(d)/local > > %: > - dh $@ --with quilt,autoreconf > + dh $@ --with quilt,autoreconf,dwz --parallel > > # avoid libaudit-dev when bootstrapping > -ifneq (,$(filter $(DEB_BUILD_PROFILE),stage1)) > +ifneq (,$(filter pkg.pam.noaudit,$(DEB_BUILD_PROFILES))) > CONFIGURE_OPTS += --disable-audit > endif > Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ [email protected] [email protected]
signature.asc
Description: PGP signature
