Steve Langasek: > Hi Niels, > > [...] >> @@ -1,3 +1,20 @@ >> +pam (1.1.8-3.9) unstable; urgency=medium >> + >> + * Non-maintainer upload. >> + >> + [ Niels Thykier ] >> + * Enable dh_dwz to reduce the size of the dbgsym files. > > What is the NMU rationale for this change? There does not appear to be a > corresponding bug report, and there is certainly not one referenced in the > changelog.
The rationale is *exactly* what is says on the tin: Smaller dbgsym files (including the debs). Nothing more, nothing less. > This looks likely to cause build failures in some circumstances, > given the lack of corresponding build-dependency changes. > The debhelper package pulls the relevant dependency (like it does for autoreconf and autotools-dev for two other helpers) > I am not enthusiastic about pam being opted in to non-default debhelper > settings via NMU. > FTR, it is the default in debhelper compat 12 (just as note that it is becoming the default for packages that bump their compat) >> [...] > >> + [ Helmut Grohne ] >> + * Convert DEB_BUILD_PROFILE=stage1 to DEB_BUILD_PROFILES=pkg.pam.noaudit. >> + (Closes: #907492) > > Though I had not followed up on the bug report, I disagree with this change > and thus nack this NMU. I do not agree that it is preferable to use an > explicit 'pkg.pam.noaudit' profile name instead of 'stage1'. The pam > package was an early adopter of build profiles precisely for the purpose of > archive bootstrapping, and for archive bootstrapping what is interesting is > NOT that the package is built without audit, what is interesting is that it > is a bootstrap build. The fact that audit is the specific package being > excluded is a point-in-time implementation detail that should NOT be > exposed. > > Please withdraw this NMU. > >> [...] > > Thanks, > I have withdrawn my NMU as requested. I kindly ask that you at least correct debian/rules to use the *correct* variable in debian/rules for buster (or allow me to do so), so bootstrapers do not have monkey patch the pam sources to perform the bootstrap. I.e. change DEB_BUILD_PROFILE -> DEB_BUILD_PROFILES (and then we can leave the actual profile at "stage1" for now. Thanks, ~Niels
