tag 351268 +pending
thanks

On Fri, Feb 03, 2006 at 07:23:31PM +0100, Mike Hommey wrote:
> Package: e2fslibs-dev
> Version: 1.38+1.39-WIP-2005.12.31-1
> Severity: minor
> 
> In documentation and comments in the .h file, BLOCK_FLAG_DEPTH_TRAVERSE
> is said to be BLOCK_FLAG_TRAVERSE. Either one or the other is wrong.

Thanks for pointing this out.  The following has been checked into the
e2fsprogs repository.

                                                - Ted

# HG changeset patch
# User [EMAIL PROTECTED]
# Node ID e08dcf4f1666eba6d17fedc47bd57343abf5b50b
# Parent  d13d67551d6bd7a3322a1654d761d76144f70f65
Fix documentation: BLOCK_FLAG_TRAVERSE should be BLOCK_FLAG_DEPTH_TRAVERSE

Addresses Debian Bug #351268

Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]>

diff -r d13d67551d6b -r e08dcf4f1666 doc/ChangeLog
--- a/doc/ChangeLog     Fri Mar 17 21:59:13 2006 -0500
+++ b/doc/ChangeLog     Sat Mar 18 08:26:36 2006 -0500
@@ -1,3 +1,9 @@
+2006-03-18  Theodore Ts'o  <[EMAIL PROTECTED]>
+
+       * libext2fs.texinfo (Iterating over blocks in an inode): Fix
+               BLOCK_FLAG_TRAVERSE so it is the correct
+               BLOCK_FLAG_DEPTH_TRAVERSE.  (Addresses Debian Bug #351268)
+
 2006-06-30  Theodore Ts'o  <[EMAIL PROTECTED]>
 
        * Release of E2fsprogs 1.38
diff -r d13d67551d6b -r e08dcf4f1666 doc/libext2fs.texinfo
--- a/doc/libext2fs.texinfo     Fri Mar 17 21:59:13 2006 -0500
+++ b/doc/libext2fs.texinfo     Sat Mar 18 08:26:36 2006 -0500
@@ -516,7 +516,7 @@
 also known as BLOCK_FLAG_APPEND, since it is also used by functions
 such as ext2fs_expand_dir() to add a new block to an inode.
 
[EMAIL PROTECTED] BLOCK_FLAG_TRAVERSE
[EMAIL PROTECTED] BLOCK_FLAG_DEPTH_TRAVERSE
 This flag indicates that the iterator function for the
 indirect, doubly indirect, etc. blocks should be called after all
 of the blocks containined in the indirect blocks are processed.
diff -r d13d67551d6b -r e08dcf4f1666 lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog      Fri Mar 17 21:59:13 2006 -0500
+++ b/lib/ext2fs/ChangeLog      Sat Mar 18 08:26:36 2006 -0500
@@ -1,3 +1,8 @@
+2006-03-18  Theodore Ts'o  <[EMAIL PROTECTED]>
+
+       * ext2fs.h: Fix documentation so that BLOCK_FLAG_TRAVERSE is
+               BLOCK_FLAG_DEPTH_TRAVERSE.  (Addresses Debian Bug #351268)
+
 2006-03-17  Theodore Ts'o  <[EMAIL PROTECTED]>
 
        * initialize.c (calc_reserved_gdt_blocks): Fix a signed vs
diff -r d13d67551d6b -r e08dcf4f1666 lib/ext2fs/ext2fs.h
--- a/lib/ext2fs/ext2fs.h       Fri Mar 17 21:59:13 2006 -0500
+++ b/lib/ext2fs/ext2fs.h       Sat Mar 18 08:26:36 2006 -0500
@@ -269,9 +269,9 @@
  * to an inode.  It can also be used for programs that want to be able
  * to deal with files that contain "holes".
  * 
- * BLOCK_FLAG_TRAVERSE indicates that the iterator function for the
- * indirect, doubly indirect, etc. blocks should be called after all
- * of the blocks containined in the indirect blocks are processed.
+ * BLOCK_FLAG_DEPTH_TRAVERSE indicates that the iterator function for
+ * the indirect, doubly indirect, etc. blocks should be called after
+ * all of the blocks containined in the indirect blocks are processed.
  * This is useful if you are going to be deallocating blocks from an
  * inode.
  *


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to