On 2019-02-17 15:55 +0000, Scott Kitterman wrote:

> Can you change:
>
> Linux.[34].*) SYSTYPE=LINUX$RELEASE_MAJOR
>
> to:
>
> Linux.[345].*) SYSTYPE=LINUX$RELEASE_MAJOR
>
> in makedefs and verify it builds and works (just a smoke test is fine)
> with your kernel?

I also had to change src/util/sys_defs.h:

diff --git a/src/util/sys_defs.h b/src/util/sys_defs.h
index f4f53300..6a5da4fe 100644
--- a/src/util/sys_defs.h
+++ b/src/util/sys_defs.h
@@ -748,7 +748,7 @@ extern int initgroups(const char *, int);
  /*
   * LINUX.
   */
-#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4)
+#if defined(LINUX2) || defined(LINUX3) || defined(LINUX4) || defined(LINUX5)
 #define SUPPORTED
 #define UINT32_TYPE	unsigned int
 #define UINT16_TYPE	unsigned short
After that, postfix builds.  And if you receive this mail, it also
works. :-)

> I'm having discussions with upstream about this and
> that would be helpful in moving things forward.

It might be better to use a single SYSTYPE for all current and future
Linux kernels, e.g. like this:

diff --git a/makedefs b/makedefs
index 227fdd54..bd3ab32e 100644
--- a/makedefs
+++ b/makedefs
@@ -546,7 +546,7 @@ EOF
 		: ${SHLIB_ENV="LD_LIBRARY_PATH=`pwd`/lib"}
 		: ${PLUGIN_LD="${CC-gcc} -shared"}
 		;;
-  Linux.[34].*)	SYSTYPE=LINUX$RELEASE_MAJOR
+  Linux.[3456789].*)	SYSTYPE=LINUX3
 		case "$CCARGS" in
 		 *-DNO_DB*) ;;
 		 *-DHAS_DB*) ;;
That buys some additional time until Linux 10 comes along.

Cheers,
       Sven

Reply via email to