The "--release 8" fix seems fine, my only concern is that someone needs to test this, since it is different than what upstream does. I suppose that the autopkgtest is complete enough to test this. I'm not really aware of whether there are security concerns of compiling with different source/target/release versions. Do you know?
.hc Tiago Daitx: > Indeed, openjdk-8 is planned to be removed from buster, but any user > that tries to run apksigner with a java 8 level binary (from openjdk, > oracle, or other vendors) will be unable to do so. In addition to that > Debian derivatives might be affected: Ubuntu is keeping openjdk-8 > available for users and to avoid such simply delta I am proposing the > patch to Debian. > > The early changelog entry related to the "-source 8" change stated > that this was done to support java 8 level, but it missed the fact > that it should actually have added "-target 8" at the least. I am > aiming to fix that with the "--release 8" flag which is the proper way > to set source/target since OpenJDK 9. > > Please note that the jh_build tool from javatools package has a bug > that causes this package to currently FTBFS (with or without my change > as the bug forces -source 7 -target 7 to be used which is incompatible > with the level 8 source code): https://bugs.debian.org/925617 > > Regards, > Tiago > > On Mon, Mar 25, 2019 at 4:52 PM Hans-Christoph Steiner <[email protected]> wrote: >> >> >> Can you tell me more about the use case for this? my understanding is >> that openjdk-8 will not be supported in buster. >> >> .hc >> >> Tiago Daitx: >>> Hi, >>> >>> Please consider my upload to mentors as a fix for this issue >>> https://mentors.debian.net/package/android-platform-tools-apksig >>> https://mentors.debian.net/debian/pool/main/a/android-platform-tools-apksig/android-platform-tools-apksig_0.8-3.dsc >>> >>> Regards, >>> Tiago >>> >>> _______________________________________________ >>> Android-tools-devel mailing list >>> [email protected] >>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/android-tools-devel >>> > > >
