Hi Thorsten, Le 02/04/2019 à 16:54, Thorsten Glaser a écrit :
> due to your objection against perceived complexity, I changed the way > I’ve implemented this. Doing this at all is required because the hard > “Depends: systemd” will not work on many non-systemd systems What is the issue with the dependency on systemd? I was under the impression systemd-sysusers could be used even on systems using sysvinit as the init system. I understand it won't work on Debian derivatives that vowed to burn any systemd related code, but that's not the matter here. > diff --git a/debian/tomcat9.postinst b/debian/tomcat9.postinst > index 55fb55c2..8edcfc5c 100644 > --- a/debian/tomcat9.postinst > +++ b/debian/tomcat9.postinst > @@ -5,6 +5,7 @@ > > set -e > > +# Note these are no longer configurable (as of commit > 243d00dc688ea47f4c7cde570ccaaa70efe269bf) > TOMCAT_USER="tomcat" > TOMCAT_GROUP="tomcat" The comment doesn't add much value. The non configurable user/group is already documented in the changelog. > > @@ -12,8 +13,8 @@ CONFFILES="tomcat-users.xml web.xml server.xml > logging.properties context.xml ca > > case "$1" in > configure) > - # Create the tomcat user as defined in /usr/lib/sysusers.d/tomcat9.conf > - systemd-sysusers > + # Create the tomcat user > + /usr/libexec/tomcat9/create-sysuser.sh If systemd-sysusers can't be used directly I prefer an inline code to an external file. Emmanuel Bourg
