severity 907907 serious
tags 907907 + patch
thanks

Hi.

I did a "grep FAIL:" on the build logs and found that there is a single
failing test which is to blame for most of the build failures, namely:

--- FAIL: TestConcurrentMutationsReadModifyAndGC (2.39s)

If the package is useful "as is" and it's not broken because of this
test failing randomly, then disabling it is the only sensible thing
to do.

By taking "0003-skip-random-failed-test" as an example, I believe
the patch below is the right way to disable it, and in fact after
applying the patch I see this in the build logs instead:

--- SKIP: TestConcurrentMutationsReadModifyAndGC (0.00s)

Additionally, I've setup a Jenkins job here so you can see the sorry
state of the package in its current version:

https://jenkins-1.reliable-builds.org/job/golang-google-cloud/

Please, please, please, let us not release buster with packages
failing randomly like this.

[ Note: If you still think the failing test should be debugged and not
  disabled for buster, please contact me privately and I will gladly
  offer a test machine where this happens a lot ].

Thanks.

--- a/bigtable/bttest/inmem_test.go
+++ b/bigtable/bttest/inmem_test.go
@@ -30,6 +30,7 @@ import (
 )
 
 func TestConcurrentMutationsReadModifyAndGC(t *testing.T) {
+       t.Skip("skip random failed tests")
        s := &server{
                tables: make(map[string]*table),
        }

Reply via email to