mh, no.  I think some logic needs tweaking, as file is definitely present
(it's an hard dependency of diffoscope), and that test should just be
skipped.

On Thu, Jul 11, 2019 at 11:42 PM Chris Lamb <la...@debian.org> wrote:

> Steve Langasek wrote:
>
> > At the very least, it seems this should be a versioned test dep on file
> (>=
> > 5.37), but perhaps it should also be a versioned runtime dependency. I
> > haven't looked to see what the impact is of the wrong version of 'file'
> when
> > DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS is not set.
>
> I think we need to add "file" to the DIFFOSCOPE_TESTS_MISSING_TOOLS
> list in debian/tests/pytest. Mattia, can you confirm?
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      la...@debian.org 🍥 chris-lamb.co.uk
>        `-
>
>

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Reply via email to