Hello, Missatge de László Böszörményi (GCS) <g...@debian.org> del dia dj., 17 d’oct. 2019 a les 8:32: > On Wed, Oct 16, 2019 at 6:23 PM Hector Oron <zu...@debian.org> wrote: > > Missatge de László Böszörményi (GCS) <g...@debian.org> del dia dc., 16 > > d’oct. 2019 a les 17:34: > > > On Wed, Oct 16, 2019 at 12:24 PM Héctor Orón Martínez <zu...@debian.org> > > > wrote: > > > > Please, could you please review the changes and either accept them or > > > > comment on further changes. > > > Did you try to build it with the current protobuf version available > > > in experimental? > > > > Not really, I need the package for stretch, which involves a bit of > > backporting stuff, I'll try that tomorrow. > Tested and unfortunately it doesn't compile. There's no sense to > merge your work, sorry. > But it seems to be good for your backporting efforts (compiles with > older protobuf version).
Actually, not entirely sure why, the package does not have third-party upb, so the build (on stretch) fails with: [ 243s] mkdir -p `dirname /usr/src/packages/BUILD/objs/opt/src/core/lib/security/credentials/alts/alts_credentials.o` [ 243s] c++ -Ithird_party/googletest/googletest/include -Ithird_party/googletest/googlemock/include -Ithird_party/address_sorting/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -Wall -Wextra -DOSATOMIC_USE_INLINED=1 -Ithird_party/upb -Isrc/core/ext/upb-generated -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude -I/usr/src/packages/BUILD/gens -DNDEBUG -DINSTALL_PREFIX=\"/usr\" -DGRPC_HAVE_PERFTOOLS -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -fno-rtti -fno-exceptions -MMD -MF /usr/src/packages/BUILD/objs/opt/src/core/lib/security/credentials/alts/alts_credentials.dep -c -o /usr/src/packages/BUILD/objs/opt/src/core/lib/security/credentials/alts/alts_credentials.o src/core/lib/security/credentials/alts/alts_credentials.cc [ 243s] In file included from ./src/core/tsi/alts/handshaker/transport_security_common_api.h:29:0, [ 243s] from ./src/core/lib/security/credentials/alts/grpc_alts_credentials_options.h:26, [ 243s] from ./src/core/lib/security/credentials/alts/alts_credentials.h:26, [ 243s] from src/core/lib/security/credentials/alts/alts_credentials.cc:21: [ 243s] src/core/ext/upb-generated/src/proto/grpc/gcp/transport_security_common.upb.h:12:32: fatal error: upb/generated_util.h: No such file or directory [ 243s] #include "upb/generated_util.h" [ 243s] ^ [ 243s] compilation terminated. > > > I've already packaged it myself. Why I didn't and can't push it to > > > Salsa is that it needs two source tarballs now. Do you know how to > > > handle this with gbp? > > > gbp import-orig works with only one source as I've seen. > > > > Have a look to > > https://git.sigxcpu.org/cgit/git-buildpackage/commit/?id=f9ded2f342e8b22171cbadb3d7e55830eff21823 > > hopefully that gives you a better clue. > A quick test showed that --component works fine. Going to update the > packaging on next Tuesday when I get back home. Sounds excellent! I'll test it. Regards -- Héctor Orón -.. . -... .. .- -. -.. . ...- . .-.. --- .--. . .-.
