Quoting andreimpope...@gmail.com (2019-12-15 16:50:17) > On Mi, 11 dec 19, 03:19:16, Jonas Smedegaard wrote: > > > > Thanks¹ for the attached patch. > > > > Looks great! > > Thanks :) > > > One detail: Seems more sensible to me to by default check for and > > include addon config if it exists - i.e. not only if uncommented in > > main config as in your proposed patch. > > > > Do you have some opinion on that? > > After thinking about this for a while it seems to me like the custom > entries are a solution of last resort and should not be activated by > default.
I don't understand what you mean gets "activated by default": By default no custom file exists, and therefore none is "activated". Reason I prefer having that entry uncommented by default is to not need editing main file when adding a custom file. Main file is a conffile so the fewer situations it needs editing the better. Compare to config parsers supporting slurping config.d entries: When the admin or another package adds the entry, it get included _without_ needing to touch the main conffile. > For me it would make more sense to add some more variables to generate > different entries, e.g. something like U_BOOT_ALT_ROOT (alternative > root file system for which to generate entries). Sorry, I don't understand what you are saying here. Seems to you are switching topic to discuss something else, is that correct? Kind regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
