Hi Eli,

thanks for the report.

> - Fix-Markdown-module-loader.patch
> - Remove-Qt4-hack.patch/

Disabled for the next package version based on 4.99.2

> - Use-packaged-instead-of-bundled-feedparser-Python-module.patch
> - Don-t-load-external-URLs-for-privacy.patch

Not actually used, please look into debian/patches/series for actually
used patches (ok, I should clean up!)

> - Disable-update-check-by-default.patch
> 
> While I'm on the topic of Debian-specific patches... this patch seems to
> cause calibre to start up with the update checker disabled, but that
> will disable both the application version check and the plugins version
> check, and I don't believe the latter is appropriate to disable. Please
> check if this is overreaching, and find a more targeted patch if so.

Indeed, but I think this was the original idea. Programs should not
start up and contact outside entities by default - at least this is what
I learned back then, maybe this is not a requirement anymore.

I will check back with debian-devel. I would change the patch to make
it only check for updated plugins. We don't want users to try to mess up
the dpkg version with some hand-updates as root, that will not work out.

The patches that will be used (atm) for the package I am preparing are
- Disable-update-check-by-default.patch
        see above
- Fix-desktop-integration-installation.patch
        I am surprised that on Arch nothing like this is necessary ...
        When I do this on Debian, the calibre installer tries to
        actually install into system directories
- no-detach-in-desktop-files
        also something reasonable I think
- Hardening-Qt-code.patch
        same with that

So I really think that Debian packages do **not** degress from upstream
as far as it is always assumed. The only *functional* change is the
update check, which, as I wrote, is a requirement AFAIR of Debian.

Thanks

Norbert

--
PREINING Norbert                               http://www.preining.info
Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

Reply via email to