Hi Guilhem, On Tue, Jul 21, 2020 at 01:45:28AM +0200, Guilhem Moulin wrote: > While it's difficult to change the default value for Rules-Requires-Root: > in dpkg-buildpackage, it's arguably less intrusive to do it in lintian-brush > (at least in opinionated mode) as the maintainer has a chance to review > the changes and compare binary packages before uploading. > > The attached fixer can be used to unconditionally set ‘Rules-Requires-Root: > no’. > I suppose it would be better to have some heuristics to try to guess > whether d/rules requires root privileges, but for packages with simple d/rules > and where upstream tests don't require privileged access the fixer is > probably good enough :-) Thanks for the patch!
I've committed this fixer to master with some minor changes. lintian-brush works with certainty levels. By default, only changes with certainty "certain" are included, with the idea that maintainers can just fire and forget when running lintian-brush. This script is now included with certainty "possible". "lintian-brush --uncertain" will make lower certainty changes, and warn when it does so. Jelmer
