Control: reopen -1
On 2020-06-24 21:06 +0200, Sven Joachim wrote:
> Control: tags -1 + patch
>
> On 2020-06-24 20:53 +0200, Sven Joachim wrote:
>
>> Source: util-linux
>> Version: 2.35.1-1
>> Severity: important
>> Tags: FTBFS
>>
>> Your package fails to build on the kfreebsd and hurd ports, because it
>> invokes dh_makeshlibs for the packages libmount1{,-udeb} which do not
>> exist on these architectures.
>>
>> ,----
>> | dh_makeshlibs -plibmount1 -V \
>> | --add-udeb=libmount1-udeb
>> | dh_makeshlibs: error: The udeb libmount1-udeb does not contain any
>> | shared libraries but --add-udeb=libmount1-udeb was passed!?
>> | debian/rules:147: recipe for target 'override_dh_makeshlibs' failed
>> `----
>
> The attached patch should fix that, although I have not tested it.
Thanks for applying my patch, however it turned out to be wrong. :-(
>> From 710926f9248f680feb514fb70bd33898dfe0c577 Mon Sep 17 00:00:00 2001
> From: Sven Joachim <[email protected]>
> Date: Wed, 24 Jun 2020 21:00:49 +0200
> Subject: [PATCH 1/1] Do not invoke dh_makeshlibs for libmount1 on non-linux
> arches
>
> It does not exist there, leading to an error from dh_makeshlibs.
I should have read debian/control more carefully. Actually libmount1 is
built everywhere, only libmount1-udeb is specific to Linux.
> diff --git a/debian/rules b/debian/rules
> index 784cf20d2..e985fe25e 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -153,8 +153,10 @@ override_dh_makeshlibs:
> --add-udeb=libblkid1-udeb
> dh_makeshlibs -plibfdisk1 -V \
> --add-udeb=libfdisk1-udeb
> +ifeq ($(DEB_HOST_ARCH_OS),linux)
> dh_makeshlibs -plibmount1 -V \
> --add-udeb=libmount1-udeb
> +endif
> dh_makeshlibs -plibuuid1 -V \
> --add-udeb=libuuid1-udeb
>
This lead to the following error in the hurd-i386 build[1]:
,----
| dpkg-shlibdeps: error: no dependency information found for
/usr/lib/i386-gnu/libmount.so.1 (used by debian/util-linux/sbin/fsck)
`----
New patch is attached which hopefully fixes that, however it is still
untested because I don't have a hurd or kfreebsd system.
Cheers,
Sven
1.
https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=hurd-i386&ver=2.35.2-9&stamp=1595386182&raw=0
From 7698d4ee0dd12df231e5e6f661ec58ee4cc6bfd8 Mon Sep 17 00:00:00 2001
From: Sven Joachim <[email protected]>
Date: Wed, 22 Jul 2020 10:38:46 +0200
Subject: [PATCH 1/1] Re-add dh_makeshlibs call on non-Linux arches
Actually libmount1 exists there and is used by fsck, only
libmount1-udeb does not exist.
Closes: #963625
---
debian/rules | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/rules b/debian/rules
index badff4732..24e5d5e36 100755
--- a/debian/rules
+++ b/debian/rules
@@ -157,6 +157,8 @@ override_dh_makeshlibs:
ifeq ($(DEB_HOST_ARCH_OS),linux)
dh_makeshlibs -plibmount1 -V \
--add-udeb=libmount1-udeb
+else
+ dh_makeshlibs -plibmount1 -V
endif
dh_makeshlibs -plibuuid1 -V \
--add-udeb=libuuid1-udeb
--
2.28.0.rc1
