On 2020-05-28, Vagrant Cascadian wrote: > The example Makefile shipped in libstatgrab-dev changes depending on the > build path and if the system was build with a merged /usr > (a.k.a. usrmerge) filesystem layout. > > The attached patches fix these issues, though it might be worth > considering dropping the example Makefile from the package entirely; the > end-user would have to regenerate it themselves in order for it to be > functional.
On further consideration, I think the better option is to ship Makefile.in and Makefile.am instead of the generated Makefile, allowing someone wishing to use the example to regenerate the Makefile to match thier system. Patch attached. Is it too late to consider uploading soon for inclusion in bullseye? If you are ok with it but do not have the time, would you be ok with an NMU? Thanks for maintaining libstatgrab! live well, vagrant
From 1731bb3e8cc43ec7b23e5bb4efaef0a391060fd0 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian <[email protected]> Date: Sun, 3 Jan 2021 21:15:18 +0000 Subject: [PATCH] libstatgrab-dev.examples: Install Makefile.am and Makefile.in instead of Makefile. (Closes: #961747) The example Makefile embeds build paths that are not likely to be present on the end-user system, and possibly binary paths that may be different on a usrmerge system, thus requiring the end-user to regenerate the file from the Makefile.in or Makefile.am in order to function correctly. --- debian/libstatgrab-dev.examples | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/libstatgrab-dev.examples b/debian/libstatgrab-dev.examples index 44f63b7..e846f57 100644 --- a/debian/libstatgrab-dev.examples +++ b/debian/libstatgrab-dev.examples @@ -1,2 +1,2 @@ examples/*.c -examples/Makefile +examples/Makefile.* -- 2.20.1
signature.asc
Description: PGP signature
