El 28/02/22 a las 16:26, Martin-Éric Racine escribió: > On Mon, Feb 28, 2022 at 12:45 PM Santiago R.R. <santiag...@riseup.net> wrote: > > > > (Removing some people from CC to avoid polluting their mailboxes) > > > > El 25/02/22 a las 11:25, Martin-Éric Racine escribió: > > > On Fri, Feb 25, 2022 at 10:31 AM Roy Marples <r...@marples.name> wrote: > > > > > > > > On 24/02/2022 21:31, Santiago R.R. wrote: > > > > > > > > > > On February 24, 2022 10:21:38 PM GMT+01:00, "Santiago R.R." > > > > <santiag...@riseup.net> wrote: > > > > >> > > > > >> On February 24, 2022 9:38:36 AM GMT+01:00, "Martin-Éric Racine" > > > > <martin-eric.rac...@iki.fi> wrote: > > > > >>> Package: dhcpcd5 > > > > >>> Followup-For: Bug #964947 > > > > >>> X-Debbugs-Cc: > > > > sc...@sl.id.au,r...@marples.name,santiag...@riseup.net,mp...@debian.org > > > > >>> > > > > > I have an NMU waiting on Mentors. > > > > > > > > > > <https://mentors.debian.net/debian/pool/main/d/dhcpcd5/dhcpcd5_9.4.1-0.1.dsc> > > > > > > > > > >> Thanks for your work! I do not have too much free cycles, but I will > > > > >> do my best to review and upload it soon. > > ... > > > > I forgot to say I hope Scott is doing well. I hope his lack of activity > > is just a lack of available time. > > The last upload was made in May 2019 i.e. oldstable. > > Bug #964947 requesting the packaging of current version was filed in > July 2020. That's nearly 2 years ago. It remains unanswered by Scott > despite recent activity on the bug. My packaging therefore assumes > that Scott is MIA and focuses on bringing the package closer to what's > expected for contemporary usage. > > > * You are moving stuff to /usr. Do you have any reason for making this > > change in this NMU? > > While I think it is a good thing, this is not documented in > > d/changelog, and I think an NMU should focus on the reason for doing it > > (the newest upstream release in this case). > > From the developers reference (5.11.1.): "...Fixing cosmetic issues or > > changing the packaging style in NMUs is discouraged." > > I try to keep the delta with upstream defaults as small as possible. > Upstream uses /usr. The only thing that doesn't work as expected is > that upstream's configure script fails at putting the prefix for > manual pages. > > As a side-issue, Lintian incorrectly reports the upstream default for > its lease database (/var/db) as non-standard. See Bug#1006482. Because > of this, I've kept the directory unchanged for now.
Sorry, just to be sure of understanding, are you reverting the move to /usr? If yes, please tell me when you have a new version to review. Otherwise, please document it in d/changelog. > > If Debian followed FHS by the book, we would probably want the DHCP > client to sit in /sbin since it's needed to bring up the network and > /usr may be mounted later during bootup. Since Debian doesn't mount > /usr separately, using upstream defaults works as-is. > > > This also concerns the minor bump version number in d/watch. > > It was a low-hanging fruit and verified to work. Yes, I can acknowledge that. But again, I have some doubts that's the changes that should be expected in an NMU. > > > * Could you please fix the indentation of the your new entry in d/copyright? > > IMHO, the whole file's indentation needs to be fixed. I had troubles > aligning my addition, because the file currently uses TAB+2SPACES. > There really should be a linting tool for that. Idem. > > > * Part of the changes you are including had already been done in the VCS > > by Scott. There is no rule about this, but *I* would give credit to > > him. Maybe I would have cherry-picked the relevant changes needed for > > packaging this new upstream release, and use `gdp dch`. This is up to > > you. > > I have not checked what's in VCS since no upload has taken place since > 2019 and no reaction to bugs has take place since then either. > > > * Could you please tell me how have you tested it? > > For the past week, it's been the DHCP client on an host that matches > upstream assumptions: hotpluggable Ethernet or USB WiFi dongles. The > host in question has Ethernet, and I've randomly used a variety of USB > dongles to test WiFi support. Configuring wpa_supplicant manually > via/etc/wpa_supplicant/wpa_supplicant.conf rather than passing the > SSID and PSK key via /etc/network/interfaces required a lot of > googling but works as expected. This initially didn't work as > expected, because the package was not compiled with libudev and > upstream's BUILDING.md makes no mention of what libraries may be used > to enable some features. That's how I ended up adding the Build-Dep. Great, thank you! -- Santiago
signature.asc
Description: PGP signature
