On 2022-06-24 16:53:20, Georges Khaznadar wrote:
> Hello, please find as an attachment a patch to fix #1012190 and #981703
> and close them.
Hi,
thanks for the patches.
I am note sure they work though, see my comments below...
> --
> Georges KHAZNADAR et Jocelyne FOURNIER
> 22 rue des mouettes, 59240 Dunkerque France.
> Téléphone +33 (0)3 28 29 17 70
>
> diff --git a/debian/changelog b/debian/changelog
> index f5795bd..2c59b7e 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,18 @@
> +slop (7.6-2.1) unstable; urgency=medium
> +
> + * Non-maintainer upload.
> + * added a file d/libslop7.6.shlibs; #closes: #1012190
I don't understand why this is necessary. #1012190 should be closed
automatically when 7.6 migrates to testing, it's already marked as fixed
in unstable, deliberately.
> + * modified d/control
> + + now libslop7.6 conflicts with libslop7.5 and replaces it
libslop7.5 doesn't exist as far as I know, why is that necessary?
> + + added a strict dependency libdevel =>
> + libslopy7.6(>= ${source:Version}), libslopy7.6(<= ${source:Version}.1~)
shouldn't the shlibs:Depends do the right thing here?
i should also note that the bug to fix here is #1009010 and it's going
to be fixed once 7.6-2 passes NEW (which it entered yesterday).
> + * applied GSR's patch; closes: #981703
i'd rather have that merged in when upstream does that release, instead
of carrying that local patch...
> + * modified d/rules to clean out bin/slop
[...]
> diff --git a/debian/rules b/debian/rules
> index bb2a2a9..61fae45 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -20,3 +20,8 @@ export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
> # main packaging script based on dh7 syntax
> %:
> dh $@
> +
> +override_dh_auto_clean:
> + dh_auto_clean
> + # remove a binary file not cleaned by the Makefile
> + rm -f bin/slop
could you submit this upstream?
thanks.
--
Nothing incites to money-crimes like great poverty or great wealth.
- Mark Twain
