reassign 1020572 python3-debmutate thanks On Mon, Sep 26, 2022 at 07:13:24AM +0200, Yadd wrote: > On 26/09/2022 06:41, Jelmer Vernooij wrote: > > On Fri, Sep 23, 2022 at 03:48:42PM +0200, Yadd wrote: > > > now lintian-brush replaces build dependency to dh-sequence-nodejs by > > > "pkg-js-tools | dh-sequence-nodejs". This change is wrong: > > > dh-sequence-nodejs is provided by dh-nodejs, not pkg-js-tools (which has > > > a lot of dependencies and depends on dh-nodejs). > > > > > > Question, why this change, is dh-sequence-nodejs not enough ? > > > > Do you have an example where it did this? It shouldn't normally do > > this, so perhaps it's hitting some sort of corner case. > > > > Jelmer > > Hi, > > an example here: > https://salsa.debian.org/js-team/node-i18next/-/commit/da05bcd0 > > lintian-brush added a dependency to "pkg-js-tools | dh-sequence-nodejs" > while there were already a dependency to dh-sequence-nodejs
Thanks! It looks like debmutate is getting confused by the comments in the control field here, causing it to miss the existing dependency on dh-sequence-nodejs. Previously, it would refuse to touch any file with comments since it wouldn't be able to preserve the comments. The new RTS parser in python-debian now allows editing files while preserving those comments. For the moment, I think debmutate needs to: * properly ignore comments when parsing control fields * refuse to edit any control fields that embed comments Jelmer
