On Wed, 25 Jan 2023 17:45:48 +0100 Gianfranco Costamagna <[email protected]> wrote:
Source: pkgconf
Version: 1.8.1-1
tags: patch

Hello, I copy-pasted the testsuite from old src:pkg-config, and it looks still 
useful to catch some regressions.
Would it be possible to include it to make the package safer w.r.t. regressions 
and better?

And also to make it migrate in 2 days instead of 5!

Thanks for the idea, but I’m afraid this patch won’t work as it is.

diff -Nru pkgconf-1.8.1/debian/tests/control pkgconf-1.8.1/debian/tests/control
--- pkgconf-1.8.1/debian/tests/control  1970-01-01 01:00:00.000000000 +0100
+++ pkgconf-1.8.1/debian/tests/control  2023-01-25 17:27:59.000000000 +0100
@@ -0,0 +1,2 @@
+Tests: crosswrapper foreign-arch invalid-arch
+Restrictions: needs-root, allow-stderr

The crosswrapper is no more, so this needs to be done slightly differently.

diff -Nru pkgconf-1.8.1/debian/tests/foreign-arch 
pkgconf-1.8.1/debian/tests/foreign-arch
--- pkgconf-1.8.1/debian/tests/foreign-arch     1970-01-01 01:00:00.000000000 
+0100
+++ pkgconf-1.8.1/debian/tests/foreign-arch     2023-01-25 17:27:59.000000000 
+0100
@@ -0,0 +1,12 @@
+#! /bin/sh
+
+set -e
+
+dpkg --add-architecture i386

There isn’t a dpkg hook anymore, multiarch is used instead. This test would have to somehow install the correct multiarch version of the symlink-containing package.

diff -Nru pkgconf-1.8.1/debian/tests/invalid-arch 
pkgconf-1.8.1/debian/tests/invalid-arch
--- pkgconf-1.8.1/debian/tests/invalid-arch     1970-01-01 01:00:00.000000000 
+0100
+++ pkgconf-1.8.1/debian/tests/invalid-arch     2023-01-25 17:27:59.000000000 
+0100
@@ -0,0 +1,12 @@
> ...
> +# This is an intentionally invalid architecture.
> +dpkg --add-architecture x86
> +apt-get install sash

This also won’t work anymore.

--
Cheers,
  Andrej

Reply via email to