On Fri, 21 Apr 2023 at 13:02:24 +0200, Cyril Brulebois wrote:
> Summing up some out-of-band brainstorming about what “a bit crippled”
> means, it might just be libargon2-1-udeb's being built without pthread
> support:
>
> https://salsa.debian.org/debian/argon2/-/commit/31225912349933993e49f5007e97630b20465c32

>>  Never noticed that before, but that's not a regression since buster
>>  and bullseye both have the same behavior.  (At least in my test VMs;
>>  didn't compare on real hardware.)
> 
> Based on Samuel's feedback on IRC, what used to be true in 2019 might no
> longer be today; we might try and enable pthread support, and see
> whether that makes a difference.

That seems correct!  I just rebuilt argon2 0~20190702+dfsg-2 for
bookworm without the NO_THREADS=1 and injected the udeb in the .ISO.
The PBKDF benchmark result is as one would expect on a system with 4G
RAM:

        ~ # echo test | cryptsetup luksFormat --debug --batch-mode /dev/vda
        […]
        # Running argon2id() benchmark.
        # PBKDF benchmark: memory cost = 65536, iterations = 4, threads = 2 
(took 209 ms)
        # PBKDF benchmark: memory cost = 78392, iterations = 4, threads = 2 
(took 156 ms)
        # PBKDF benchmark: memory cost = 125628, iterations = 4, threads = 2 
(took 242 ms)
        # PBKDF benchmark: memory cost = 129780, iterations = 4, threads = 2 
(took 242 ms)
        # PBKDF benchmark: memory cost = 134070, iterations = 4, threads = 2 
(took 243 ms)
        # PBKDF benchmark: memory cost = 137932, iterations = 4, threads = 2 
(took 253 ms)
        # Benchmark returns argon2id() 4 iterations, 1048576 memory, 2 threads 
(for 512-bits key).
        […]

> As noted in https://mjg59.dreamwidth.org/66429.html what happens during
> installation might not get changed at all during the life of a given
> system, so if we can somewhat easily improve what happens during
> installation… :)

Ack, and given the diff that's probably a worthwhile thing to have in
bookworm :-)

-- 
Guilhem.

Attachment: signature.asc
Description: PGP signature

Reply via email to