Dear Yokota-san, Thanks for your review for my MR!
On Tue, Sep 5, 2023 at 7:50 PM yokota <yokota.h...@gmail.com> wrote: > > Hello, > > > It's confirmed to work with my package: android-platform-tools > > which currently includes a copy of lzma. > > Your patch breaks existing 7z command. > Check formats-7z and benchmark-7z-simple test in autopkgtest result. > https://salsa.debian.org/debian/7zip/-/jobs/4656760 > > In fact, /usr/lib/7zip/7z.so is not a shared library, but big fat > plugin for 7z command. > So, don't replace 7z.so with lib7zip.so.0 . Sorry for the breakage, and Thanks for the info! > 7z.so includes some C++ interface for plugin system that not needed > for liblzma.so.0 in android-platform-tools. > If you really want to 7-Zip LZMA library, try Debian lzma-dev package. > But lzma-dev package is quite obsolete because of xz-utils package. > https://tracker.debian.org/pkg/lzma lzma-dev is too old. That's why I didn't use it. src:7zip is confirmed working with my package android-platform-tools. > /usr/lib/{arch}/android/liblzma.so.0 is exists because the > android-platform-tools document says > org.apache.commons.compress.archivers.sevenz class requires this > native library. > > https://salsa.debian.org/android-tools-team/android-platform-tools/-/blob/debian/34.0.4-1/development/sdk/sdk_files_NOTICE.txt#L14611 > > The files in the package org.apache.commons.compress.archivers.sevenz > > were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/), > > which has been placed in the public domain: > > "LZMA SDK is placed in the public domain." (http://www.7-zip.org/sdk.html) The version you mentioned 9.20, I believe, is not true. Upstream uses: - https://android.googlesource.com/platform/external/lzma/+/refs/tags/platform-tools-34.0.4 https://android.googlesource.com/platform/external/lzma/+/refs/tags/platform-tools-34.0.4/C/7zVersion.h So it shows the version is at least 19.00, which is greater than src:p7zip. That's the reason I'm excited to find there's src:7zip which is the latest for lzma/7zip. > But current org.apache.commons.compress.archivers.sevenz class in > Debian libcommons-compress-java package uses org.tukaani.xz class in > Debian libxz-java package to handle LZMA. > So, I think the document is obsolete, and there is no need to install > liblzma.so.0 or other native libraries. > > Try libcommons-compress-java package to list 7z files. > 1. Install libxz-java package that not automatically installed. > 2. Type in from console: "java -jar /usr/share/java/commons-compress.jar > foo.7z" I'm not sure about java packages. src:android-platform-tools is c++ project, and doesn't use java. So my question is, if 7z.so is not proper, is it possible to expose a shared library for src:7zip? Thank you! Cheers, Roger
