Hi,

Thanks for the patch.  I committed to salsa.

Can you elaborate what do you mean by
> Though after this it'd take some effort to edit source package name.

Maybe, we can work together to fix it.  Please understand I have no idea on the
nodejs package name conventions.

Regards,

Osamu
On Fri, 2023-10-27 at 00:44 +0530, Nilesh Patra wrote:
> Control: tags -1 patch
> 
> On Thu, 26 Oct 2023 23:25:00 +0530 Akshay S Dinesh <aks...@learnlearn.in>
> wrote:
> > On Thu, 14 Jul 2022 16:37:52 +0200 Pirate Praveen 
> > <prav...@onenetbeyond.org> wrote:
> > > Control: reopen -1
> > > Control: notfixed 4.4.0-1
> > > 
> > > On Thu, 14 Jul 2022 10:54:14 +0200 Pirate Praveen
> > > <prav...@onenetbeyond.org> wrote:
> > > > Control: fixed -1 4.4.0-1
> > > > 
> > > > Looks like it is fixed in current version, closing this bug. Thanks!
> > > 
> > > Seems like I was mistaken, tried on a fresh clean chroot and it still
> > > fails.
> > > 
> > > 
> > 
> > 
> > There's this commit referencing 4.4.0-1 on June 25, 2021 
> > https://salsa.debian.org/debian/debmake/-/commit/c59f0dbc112c5aaa737e0afdacbcc193e5e17dea
> > 
> > And this commit which fixes the bug on June 26, 2021 
> > https://salsa.debian.org/debian/debmake/-/commit/7f6c310aff8bf13eb64b98aff14e5e0b2bd58301
> > 
> > And this commit on May 6, 2022 which talks about 4.4.0
> > https://salsa.debian.org/debian/debmake/-/commit/07b1e07a9d9d327778d535287fdc70ac05dbe9e4
> > 
> > I'm unsure what's what.
> 
> It sure has been committed, and it is also present in the source package
> in the archive too. Seems to me that the uploader uploaded this on May
> 6, 2022 but did not edit the date as can be confirmed from the
> upload entry as well.
> 
>         https://tracker.debian.org/news/1323132/accepted-debmake-440-1-source-
> into-unstable/
> 
> > https://packages.debian.org/sid/all/debmake/filelist is missing 
> > /usr/share/debmake/extra0desc_long/nodejs
> 
> Right that's because the changes in the commit are incomplete to fix this bug,
> since the nodejs extradesc file is never installed because it has its entry
> missing from setup.cfg.
> 
> I've attached a (one-line) patch at the end of the mail to fix this up
> properly.
> 
> > In any case, a workaround is to do
> > 
> > echo " This package contains the nodejs program." | sudo tee 
> > /usr/share/debmake/extra0desc_long/nodejs
> 
> 
> I was surprised to know that debmake tries to take the "type" field of
> the package from the directory name itself. So another workaround (this
> one is admittedly stupid) is:
> 
> > $ mv node-pretty-ms-8.0.0 pretty-ms-8.0.0
> > $ cd pretty-ms-8.0.0
> > $ debmake
> > $ cd ..
> > $ mv pretty-ms-8.0.0 node-pretty-ms-8.0.0
> 
> Though after this it'd take some effort to edit source package name.
> 
> Best,
> Nilesh
> 
> 
> diff --git a/setup.cfg b/setup.cfg
> index 57235a5..b19b18c 100644
> --- a/setup.cfg
> +++ b/setup.cfg
> @@ -54,6 +54,7 @@ console_scripts =
>                 src/extra0desc_long/dev
>                 src/extra0desc_long/doc
>                 src/extra0desc_long/lib
> +               src/extra0desc_long/nodejs
>                 src/extra0desc_long/perl
>                 src/extra0desc_long/python
>                 src/extra0desc_long/python3

Reply via email to