On Sat, Oct 28 2023 at 15:34:43 +09:00:00, Osamu Aoki
<os...@debian.org> wrote:
Hi,
On Fri, 2023-10-27 at 20:59 +0530, Pirate Praveen wrote:
On 27/10/23 8:12 PM, Osamu Aoki wrote:
> Hi,
...
> Can you elaborate what do you mean by
> > Though after this it'd take some effort to edit source package
name.
>
> Maybe, we can work together to fix it. Please understand I have
no idea on
> the nodejs package name conventions.
May be looking for a package.json or package.yaml file in the source
directory would be a better thing to detect a nodejs package.
Currently, I have 'src/debmake/analyze.py' containing:
# Javascript nodejs
elif os.path.isfile("package.json"):
para["build_type"] = "nodejs"
para["dh_with"].update({"nodejs"})
para["build_depends"].update({"pkg-js-tools"})
Should I do:
# Javascript nodejs
elif os.path.isfile("package.json") or
os.path.isfile("package.yaml"):
para["build_type"] = "nodejs"
para["dh_with"].update({"nodejs"})
para["build_depends"].update({"pkg-js-tools"})
As you noted in subsequent comment, we can skip package.yaml. Build
depends can be dh-sequence-nodejs instead of pkg-js-tools (npm2deb did
that switch).
If dh-sequence-nodejs is in Build Deps then we don't need to add --with
nodejs to dh as well.
Regards,
Osamu
