tags 1002789 - moreinfo unreproducible
tags 1002789 + patch
severity 1002789 serious
thanks
El 5/3/24 a las 13:51, Lucas Nussbaum escribió:
Right, it looks like it only builds fine if /tmp is a tmpfs. Which looks
like a valid bug, isn't it? (I can reproduce the failure on my laptop
with /tmp on the same filesystem as the build dir, and then the failure
disapears if I mount -o bind /dev/shm /tmp).
Note that closing a bug just because you don't understand it does not
look right.
I'm setting the severity to important since we know how to make it
build.
I disagree that this is a good reason to downgrade a FTBFS bug.
In my opinion, it's quite the opposite: Once that we know why it fails,
then there is not an excuse anymore for it to keep failing.
The knowledge about how to build a package should be built-in
in debian/rules, debian/control, the Makefiles, etc, not in the BTS.
I'm attaching a patch which skips the tests when we know that they
will fail, and I hope this is finally enough for Thomas to fix
the FTBFS problem in both unstable and bookworm.
Thanks.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-pycdlib (1.12.0+ds1-7) unstable; urgency=medium
+
+ * Run tests only if /tmp is in tmpfs, because otherwise they are
+ known to fail.
+
+ -- Thomas Goirand <[email protected]> Fri, 16 Aug 2024 17:55:00 +0200
+
python-pycdlib (1.12.0+ds1-6) unstable; urgency=medium
* Cleans egg-info and .pytest_cache folder on clean.
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,8 @@
UPSTREAM_GIT := http://github.com/clalancette/pycdlib
include /usr/share/openstack-pkg-tools/pkgos.make
+TMP_IS_TMPFS := $(shell egrep -q "^tmpfs[[:space:]]+/tmp[[:space:]]"
/proc/mounts && echo true || echo false)
+
%:
dh $@ --with python3
@@ -18,10 +20,12 @@ override_dh_auto_install:
pkgos-dh_auto_install --no-py2 --in-tmp
ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
+ifeq ($(TMP_IS_TMPFS),true)
set -e ; set -x ; for pyvers in $(PYTHON3S); do \
PATH=$$PATH:$(CURDIR)/debian/tmp/usr/bin
PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages python$$pyvers -m
pytest tests -k 'not test_volumedescdate_new_nonzero and not
test_gmtoffset_from_tm'; \
done
endif
+endif
override_dh_python3:
dh_python3 --shebang=/usr/bin/python3
