Bug#1089450: tcptraceroute: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 12:57:14 -0800

Source: tcptraceroute
Version: 1.5beta7+debian-4.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
tcptraceroute failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
configure.ac:216: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:216: the top level
configure.ac:236: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:236: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:236: the top level
configure.ac:258: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:258: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:258: the top level
configure.ac:276: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:276: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:276: the top level
configure.ac:16: installing './compile'
Makefile.am: installing './depcomp'
   dh_auto_configure

./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking

checking build system type... aarch64-unknown-linux-gnu
checking host system type... aarch64-unknown-linux-gnu
checking target system type... aarch64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out

checking for suffix of executables... checking whether we are cross compiling... no

checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of gcc... none
checking for gethostbyname... yes
checking for socket... yes
checking for connect... yes
checking for inet_aton... yes
checking for pcap_open_live in -lpcap... yes
checking for main in -lnet... yes
checking for libnet_init_packet in -lnet... no
checking for libnet_init in -lnet... yes
configure: libnet version: >= 1.1.0
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for sys/time.h... yes
checking for sys/select.h... yes
checking for sys/socket.h... yes
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for arpa/inet.h... yes
checking for fcntl.h... yes
checking for netdb.h... yes
checking for netinet/in.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for sys/ioctl.h... yes
checking for sys/socket.h... (cached) yes
checking for unistd.h... (cached) yes
checking for sockaddr.sa_len... no
checking for struct sockaddr.sa_len... no
checking for GNU libc compatible malloc... yes
checking types of arguments for select... int,fd_set *,struct timeval *
checking for vprintf... yes
checking for gettimeofday... yes
checking for memset... yes
checking for select... yes
checking for socket... (cached) yes
checking for strchr... yes
checking for Solaris... no
checking for BSDI... no
checking for NetBSD... no
checking for MacOS X... no
Target OS is linux-gnu
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
   dh_auto_build
        make -j16
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make  all-am
make[2]: Entering directory '/<<PKGBUILDDIR>>'

gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -c -o main.o main.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -c -o datalink.o datalink.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -c -o util.o util.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -c -o probe.o probe.c gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -c -o capture.o capture.c

main.c: In function ‘defaults’:

main.c:73:17: warning: ‘pcap_lookupdev’ is deprecated: use 'pcap_findalldevs' and use the first device [-Wdeprecated-declarations]

   73 |                 device = pcap_lookupdev(errbuf);
      |                 ^~~~~~
In file included from /usr/include/pcap.h:43,
                 from tcptraceroute.h:38,
                 from main.c:23:
/usr/include/pcap/pcap.h:444:18: note: declared here
  444 | PCAP_API char   *pcap_lookupdev(char *);
      |                  ^~~~~~~~~~~~~~
main.c: In function ‘main’:

main.c:538:9: warning: ignoring return value of ‘setuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]

  538 |         setuid(getuid());
      |         ^~~~~~~~~~~~~~~~

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o tcptraceroute main.o datalink.o util.o probe.o capture.o -lnet -lpcap make[2]: Leaving directory '/<<PKGBUILDDIR>>'

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
        make -j16 check "TESTSUITEFLAGS=-j16 --verbose" VERBOSE=1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_prep
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_install

make -j16 install DESTDIR=/<<BUILDDIR>>/tcptraceroute-1.5beta7\+debian/debian/tcptraceroute AM_UPDATE_INFO_DIR=no

make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Entering directory '/<<PKGBUILDDIR>>'
 /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/bin'

/usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/share/doc/tcptraceroute' /usr/bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/share/man/man1' /usr/bin/install -c tcptraceroute '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/bin' /usr/bin/install -c -m 644 AUTHORS COPYING ChangeLog NEWS README examples.txt tcptraceroute.1.html tcptraceroute.lsm '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/share/doc/tcptraceroute' /usr/bin/install -c -m 644 tcptraceroute.1 '/<<PKGBUILDDIR>>/debian/tcptraceroute/usr/share/man/man1'

make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'

mv debian/tcptraceroute/usr/bin/tcptraceroute debian/tcptraceroute/usr/bin/tcptraceroute.mt mv debian/tcptraceroute/usr/share/man/man1/tcptraceroute.1 debian/tcptraceroute/usr/share/man/man1/tcptraceroute.mt.1

chmod 4755 debian/tcptraceroute/usr/bin/tcptraceroute.mt
chown root:root debian/tcptraceroute/usr/bin/tcptraceroute.mt

chown: changing ownership of 'debian/tcptraceroute/usr/bin/tcptraceroute.mt': Operation not permitted

make[1]: *** [debian/rules:27: override_dh_auto_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:17: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-18T16:58:12Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1047412.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089450: tcptraceroute: Supporting rootless builds by default

Reply via email to