Bug#1089454: tiger: Supporting rootless builds by default

[Niels Thykier]

Source: tiger
Version: 1:3.2.4~rc1-3.2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
tiger failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
rm -f ../html/*.html
rm -f Makefile *.html explain.idx
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
find log/ -type f -exec rm -f {} \;
find: ‘log/’: No such file or directory
make[1]: [Makefile.in:311: distclean] Error 1 (ignored)
find run/ -type f -exec rm -f {} \;
find: ‘run/’: No such file or directory
make[1]: [Makefile.in:312: distclean] Error 1 (ignored)
rm -f Makefile config.{status,log,cache} man/tiger.8 man/tigercron.8
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
rm -f config.{status,log,cache}
dh_clean

 debian/rules binary
dh_testdir
autoconf
configure.in:58: warning: AC_OUTPUT should be used without arguments.
configure.in:58: You should run autoupdate.

checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out

checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking for a BSD-compatible install... /usr/bin/install -c
configure: creating ./config.status
config.status: creating Makefile

config.status: creating c/Makefile
config.status: creating doc/Makefile
config.status: creating man/tiger.8
config.status: creating man/tigercron.8
/usr/bin/make all
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cd c && /usr/bin/make
make[2]: Entering directory '/<<PKGBUILDDIR>>/c'
gcc  -Wall -o getpermit getpermit.c
gcc  -Wall -o snefru snefru.c
gcc  -Wall -o md5 md5.c
gcc  -Wall -o testsuid testsuid.c
gcc  -Wall -o realpath realpath.c
make[2]: Leaving directory '/<<PKGBUILDDIR>>/c'
cd doc && /usr/bin/make
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
sh ../util/doc2html Doing ../doc/accounts.txt
Doing ../doc/aide.txt
Doing ../doc/aliases.txt
Doing ../doc/anonftp.txt
Doing ../doc/background.txt
Doing ../doc/config.txt
Doing ../doc/cron.txt
Doing ../doc/debian.txt
Doing ../doc/embed.txt
Doing ../doc/filesys.txt
Doing ../doc/group.txt
Doing ../doc/hpux.txt
Doing ../doc/inetd.txt
Doing ../doc/integrit.txt
Doing ../doc/issue.txt
Doing ../doc/known.txt
Doing ../doc/linux.txt
Doing ../doc/logfiles.txt
Doing ../doc/misc.txt
Doing ../doc/ndd.txt
Doing ../doc/netrc.txt
Doing ../doc/network.txt
Doing ../doc/nfs.txt
Doing ../doc/passwd.txt
Doing ../doc/paths.txt
Doing ../doc/pcap.txt
Doing ../doc/permissions.txt
Doing ../doc/pxt.txt
Doing ../doc/references.txt
Doing ../doc/rhosts.txt
Doing ../doc/root.txt
Doing ../doc/rootdir.txt
Doing ../doc/rootkit.txt
Doing ../doc/signature.txt
Doing ../doc/ssh.txt
BASEDIR=../ ../util/genmsgidx
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch build-stamp
dh_testdir
dh_testroot
dh_prep
dh_installdirs

/usr/bin/make install DESTDIR=debian/tiger/
make[1]: Entering directory '/<<PKGBUILDDIR>>'
Creating /usr/lib/tiger...
Creating /var/lib/tiger/work...
Creating /var/log/tiger...
Creating /usr/lib/tiger/scripts...
Creating /usr/lib/tiger/util...
Creating /usr/sbin...
Creating /etc/tiger...
Creating /usr/share/man...
Copying binaries...
Copying configuration files...
Copying general configuration...
Copying manpages...
/usr/bin/install -c -m 0444 man/tiger.8 debian/tiger//usr/share/man/man8
/usr/bin/install -c -m 0444 man/tigexp.8 debian/tiger//usr/share/man/man8
/usr/bin/install -c -m 0444 man/tigercron.8 debian/tiger//usr/share/man/man8
cd c && /usr/bin/make install
make[2]: Entering directory '/<<PKGBUILDDIR>>/c'
/usr/bin/install -c -m0755 getpermit snefru md5 testsuid realpath ../bin/
make[2]: Leaving directory '/<<PKGBUILDDIR>>/c'
cd doc && /usr/bin/make install
make[2]: Entering directory '/<<PKGBUILDDIR>>/doc'
/usr/bin/install -c -m 0644 *.html ../html/
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
Copying miscellaneous dirs...
for dir in ./bin ./check.d ./doc ./html ./scripts/sub ./systems; do \
  tar cf - $dir | (cd debian/tiger//usr/lib/tiger; tar xpf -); \
done
Copying miscellaneous files...
Copying scripts...
Copying platform scripts...
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
# This is not needed
rm -rf debian/tiger/usr/lib/tiger/man/
# Fix permission of all shell files
egrep -rl "^#\!/bin/.*sh" debian/tiger | \
        while read shell ; do chmod a+x $shell; done
# Remove CVS directories
find debian/tiger/ -type d -a -name "CVS" |xargs rm -rf
# Remove the systems that do not apply to the tiger-otheros package
# Currently only Linux and default are kept
# AIX/  default/  HPUX/  IRIX/  Linux/  NeXT/  SunOS/  UNICOS/ UNICOSMK
# TODO: make this for all dirs save for Linux and default (i.e.
# make this 'mv' more generic)

# Install configuration files
install -m 600 cronrc debian/tiger/etc/tiger/

rm -f debian/tiger/etc/tiger/tigerrc
install -m 600 debian/tiger.default debian/tiger/etc/default/tiger
install -m 600 debian/debian.ignore debian/tiger/etc/tiger/tiger.ignore
install -m 644 version.h debian/tiger/usr/lib/tiger/

chmod 0700 debian/tiger/var/lib/tiger/work
chmod 0700 debian/tiger/var/log/tiger
# Create symbolic links for Linux versions 3, 4, 5, 6 and default
[ -e debian/tiger/usr/lib/tiger/systems/Linux/3 ] || \
        ln -fs 2 debian/tiger/usr/lib/tiger/systems/Linux/3
[ -e debian/tiger/usr/lib/tiger/systems/Linux/4 ] || \
        ln -fs 2 debian/tiger/usr/lib/tiger/systems/Linux/4
[ -e debian/tiger/usr/lib/tiger/systems/Linux/5 ] || \
        ln -fs 2 debian/tiger/usr/lib/tiger/systems/Linux/5
[ -e debian/tiger/usr/lib/tiger/systems/Linux/6 ] || \
        ln -fs 2 debian/tiger/usr/lib/tiger/systems/Linux/6
[ -e debian/tiger/usr/lib/tiger/systems/Linux/default ] || \
        ln -fs 2 debian/tiger/usr/lib/tiger/systems/Linux/default
# Remove unneeded Makefile files.
rm -f debian/tiger/usr/lib/tiger/doc/Makefile
rm -f debian/tiger/usr/lib/tiger/doc/Makefile.in
# Add Desktop file
mkdir -p /<<PKGBUILDDIR>>/debian/tiger/usr/share/applications/

dh_testdir
dh_testroot
dh_install

dh_installdebconf       

dh_installdocs

dh_installexamples tigerrc* site* cronrc issue* debian/server.ignore

dh_installmenu

dh_installcron

dh_installman man/tiger.8 man/tigexp.8 man/tigercron.8

dh_installman: error: Aborting due to earlier error
make: *** [debian/rules:96: binary-arch] Error 255

--------------------------------------------------------------------------------
Build finished at 2024-11-18T17:20:05Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1047927.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

dh_clean: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_auto_configure -- --with-tigerhome=/usr/lib/tiger --with-tigerwork=/var/lib/tiger/work --with-tigerlog=/var/log/tiger --with-tigerbin=/usr/sbin --with-tigerconfig=/etc/tiger --prefix=/usr --mandir=/usr/share/man dh_auto_configure: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking --with-tigerhome=/usr/lib/tiger --with-tigerwork=/var/lib/tiger/work --with-tigerlog=/var/log/tiger --with-tigerbin=/usr/sbin --with-tigerconfig=/etc/tiger --prefix=/usr --mandir=/usr/share/man checking for suffix of executables... checking whether we are cross compiling... no config.status: WARNING: 'Makefile.in' seems to ignore the --datarootdir setting dh_installdirs: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). mv debian/tiger/usr/lib/tiger/systems/{AIX,HPUX,IRIX,NeXT,SunOS,UNICOS,UNICOSMK,Tru64,MacOSX} debian/tiger-otheros/usr/lib/tiger/systems/ # Note: Do not install tigerrc, it is handled by ucf since it is edited by Debconf prompts: # Adjust the permissions of directories that might contain confidential information install -m 0644 /<<PKGBUILDDIR>>/debian/tiger.desktop /<<PKGBUILDDIR>>/debian/tiger/usr/share/applications/ dh_install: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installdebconf: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installdocs: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installexamples: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installmenu: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installcron: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installman: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). dh_installman: error: copy(man/tiger.8, debian/tiger/usr/share/man/man8/tiger.8): Permission denied dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

OpenPGP_signature.asc
Description: OpenPGP digital signature