Package: nodejs
Version: 20.19.0+dfsg-1
Severity: important
Tags: sid patch
control: affects -1 src:openssl
User: [email protected]
Usertags: openssl-3.5
The testsuite fails with OpenSSL 3.5 (currently in experimental) due to
changed syntax in the openssl binary.
This is fixed by upstream commit
fab6906c5d1c1 ("test: update parallel/test-tls-dhe for OpenSSL 3.5")
which is attached.
Sebastian
>From fab6906c5d1c16b046187485a7cb136b3659d42b Mon Sep 17 00:00:00 2001
From: Richard Lau <[email protected]>
Date: Mon, 17 Mar 2025 03:42:55 +0000
Subject: [PATCH] test: update parallel/test-tls-dhe for OpenSSL 3.5
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.
PR-URL: https://github.com/nodejs/node/pull/57477
Refs: https://github.com/openssl/openssl/pull/26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
---
test/parallel/test-tls-dhe.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/parallel/test-tls-dhe.js b/test/parallel/test-tls-dhe.js
index b4f0337c43fa5..89cda5f52a6b3 100644
--- a/test/parallel/test-tls-dhe.js
+++ b/test/parallel/test-tls-dhe.js
@@ -85,7 +85,10 @@ function test(dhparam, keylen, expectedCipher) {
execFile(opensslCli, args, common.mustSucceed((stdout) => {
assert(keylen === null ||
- stdout.includes(`Server Temp Key: DH, ${keylen} bits`));
+ // s_client < OpenSSL 3.5
+ stdout.includes(`Server Temp Key: DH, ${keylen} bits`) ||
+ // s_client >= OpenSSL 3.5
+ stdout.includes(`Peer Temp Key: DH, ${keylen} bits`));
assert(stdout.includes(`Cipher : ${expectedCipher}`));
server.close();
}));
--
2.49.0
