Hello, On Sat 02 Aug 2025 at 08:22pm +01, Ian Jackson wrote:
> Sean Whitton writes ("Re: Bug#1108378: git-debpush: should warn for
> superfluous quilt mode option on command line"):
>> 2. make it work just like a failed check. The user has to type y and
>> then return to continue. Sounds a bit strange in the abstract but
>> might be the most useful in practice.
>
> I think this is my preference.
>
> I think it would be better not to introduce new ways to grumble.
Right, that is what I was thinking. Thanks for the review.
>> 3. just exit, requiring the user to run the command again without the
>> superfluous quilt option.
>
> Urgh, I don't like this, UX.
Me neither.
>> For all three, --batch would switch to just a printed warning.
>
> I think --batch turns failed checks into errors? That seems right
> here. If you're writing script and know you're passing a
> possibly-superfluous quilt mode, you're writing a script which
> unconditionally overrides git-debpush's determination, so you ought to
> pass a specific --force-failed-check option (I forget how those are
> spelled...)
Ah, yes, that's right.
--
Sean Whitton
signature.asc
Description: PGP signature
