Source: plymouth Version: 24.004.60-5 Severity: wishlist Tags: patch Hi,
I wanted to submit a MR on salsa about this but that seems to be broken right now, so here I'm sending it "the old fashioned way". :) Theme authors (and fellow plymouth theme packagers) might prefer to use symlinks in their themes if the files are identical to what is already shipped in other plymouth theme packages. Using cp with --dereference makes sure that if the file is a symlink, the content behind the file is copied instead of creating an initramfs with broken symlinks in it. For example there already exist multiple two-step themes and several which are very similar to the spinner theme. This commit avoids having to copy files like the throbber or the animation but instead allows creating a symlink farm to the spinner theme. This also eases copyright documentation for fellow packagers and reduces the amount of duplication in the archive. Added Bonus: if the theme contains a broken symlink, then before this commit, there was no indication of that problem. With this commit, cp will error-out if it is unable to dereference the symlink. While I was at it, I also fixed another minor thing (in the second commit): debian/local/plymouth.hook: only copy watermark.png if the theme does not include it yet Before this commit, plymouth.hook would overwrite an existing watermark.png in any theme using the two-step module. This commit allows theme creators to add their own watermark.png without having it overridden by plymouth.hook. Attached the git-format-patch. Thanks! cheers, josch
0001-debian-local-plymouth.hook-copy-theme-files-with-der.patch
Description: application/mbox
0002-debian-local-plymouth.hook-only-copy-watermark.png-i.patch
Description: application/mbox
