Package: devscripts
Version: 2.25.19
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Dear maintainer,
the Git-Modules option is broken as it will always check out all
existing submodules, even if only a partial list is given.
The culprit is the following logic error:
diff --git a/lib/Devscripts/Uscan/WatchSource.pm
b/lib/Devscripts/Uscan/WatchSource.pm
index bd0ea7f9..20d4038f 100644
- --- a/lib/Devscripts/Uscan/WatchSource.pm
+++ b/lib/Devscripts/Uscan/WatchSource.pm
@@ -421,7 +421,7 @@ sub parse {
} elsif ($optName =~ /^git(export|mode)$/) {
$self->git->{$1} = $optVal;
} elsif ($optName eq 'gitmodules') {
- - if ($optVal eq 'all' or 'yes') {
+ if ($optVal eq 'all' or $optVal eq 'yes') {
$self->git->{modules} = ['.'];
} else {
$self->git->{modules} = [split /;/, $optVal];
Cheers
Timo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEmwPruYMA35fCsSO/zIxr3RQD9MoFAmi8cbQACgkQzIxr3RQD
9Mp2bBAAj+KMLcZMBRx2FPpaLw7SGxEcTPl2JkxhbINHxx7xI7+gIVHR31kcj+l5
Xt5Srbsv0Yz0upQ1iY8ZI2P/85FXv+G7FX5vh/1HIgIkpaFG3u41X1k596tmRssZ
sBFRdvUb0QxWpylSSZdELJ62+x5dq9twZ2P96XNYgjnBq9SbUJAkErSv+KdBZwVv
MLMqGYLyb3exKpcUlDsV3/UnI0+njF556gKWhwYlFqVVlvv3L6ZF73qPaML9coKQ
2051CZZk5jhxaG56zkXc5DcS8vrtYJo+Sqv5pDGbrkTh13VVlFcZYFxS1K3h7NRH
g9JJVk6hIYdqvX9ttraeWXxF4PLKiYNyfd3YhIJVpGZ87ahggYzdJymGXsuzWjzX
BLpk5m9GJNFWO4S1Q7x8uHKyh61hx7ggTkn9WEPXUG9S5qQeSS2lhgCArvZh7jDf
oNrTc10p2e6hYoIfJF5U0ibB3JqWq3jc8dqXZyO6QFHuXcvmtA36HLXRmYeixs4j
eU4KnNtyBtiNdlUAPc2+EdFmf2DAjRH7tZzz9nmgLddY915MG01wRIFzKQGfmXfu
R5EjXwTJfNErCaH30CJRWAejwTI5oWFecV/NOD4Jav6GR2VQnizX2th8O2sE6jNG
0zp92CsCZ/Hh62HK4pq2S0dTjA8OzuV9F7WnvrGtN21i7RTxki0=
=lMXy
-----END PGP SIGNATURE-----
