Hi Timo,
On Sat, 06 Sep 2025 19:39:01 +0200 Timo Röhling wrote:
the Git-Modules option is broken as it will always check out all
existing submodules, even if only a partial list is given.
The culprit is the following logic error:
diff --git a/lib/Devscripts/Uscan/WatchSource.pm
b/lib/Devscripts/Uscan/WatchSource.pm
index bd0ea7f9..20d4038f 100644
--- a/lib/Devscripts/Uscan/WatchSource.pm
+++ b/lib/Devscripts/Uscan/WatchSource.pm
@@ -421,7 +421,7 @@ sub parse {
} elsif ($optName =~ /^git(export|mode)$/) {
$self->git->{$1} = $optVal;
} elsif ($optName eq 'gitmodules') {
- if ($optVal eq 'all' or 'yes') {
+ if ($optVal eq 'all' or $optVal eq 'yes') {
$self->git->{modules} = ['.'];
} else {
$self->git->{modules} = [split /;/, $optVal];
Sorry about this, but well spotted all the same.
This is commit 88f5af04cea55522cece131a2f3cf13aa41336fe in the salsa
repository.
Hugh
