Hello, Ian Jackson [11/Jan 2:53pm GMT] wrote: > ... >> We use 'rm -rf' to try to remove the temporary directory, because we >> think it may have already been removed. But that means the only way it >> can fail is if we're prematurely lost access to run commands, right? >> So shall we upgrade that from a warning to a failure? > > This directory has a pid or something in its path. That implies that > new ones with many different names can be generated. What ensures > that even if everything gets SIGKILL, this directory is ever deleted? > And if there *is* such a thing, why is it not sufficient even on this > codepath? > > Or to put it another way, deleting a directory on cleanup isn't > crash-only and therefore is likely to be unreliable. > > And it seesm to have a name that implies it's created by the virt > server so it's presumably the virt system's job to do any cleanup.
We've discussed this before. Any sensible virt server will clean it up. But the autopkgtest protocol doesn't require it, so we do it ourselves as a fallback. > The ProtoConn FH is a pipe, onto ssh I think, because it came from > piped open. We write to a pipe whose other end is closed. That > generates SIGPIPE. I don't understand what you don't understand... I think I get it now. -- Sean Whitton
signature.asc
Description: PGP signature
