Hello, Adam D. Barratt [17/Jan 3:33pm GMT] wrote: > On Sat Jan 17 15:28:07 2026, [email protected] wrote: >> Hello, >> >> Adam D. Barratt [17/Jan 2:59pm GMT] wrote: >> > On Sat Jan 17 14:46:04 2026, adsb wrote: >> >> FWIW the relevant part of our reboot scripts is: >> >> >> >> screen -S reboot-job -d -m sh -c 'sleep ${minwait}m ; flock >> >> /var/run/reboot-lock true; /sbin/shutdown -r 10 \"Kernel (mass) reboot >> >> issued by `whoami`.\" < /dev/null ' >> >> >> >> Are you able to determine when you should have taken the lock? If I'm >> >> reading things correctly, what /could/ happen is: >> >> >> >> T: Reboot scripts manage to obtain lock, and schedule reboot for 10 >> >> minutes later. The lock is only held for the duration of the >> >> invocation of "true". >> >> T+X: tag2upload jobs obtain lock, unaware of the already scheduled >> >> reboot >> >> T+10: Reboot >> > >> > Aurelien pointed out that molly-guard, as /sbin/shutdown, will acquire >> > the lock itself, so this seems unlikely. >> >> Hmm, but will it hold it for the whole ten minutes? > > The script in question is > https://salsa.debian.org/dsa-team/mirror/dsa-puppet/-/blob/production/modules/debian_org/files/molly-guard/15-acquire-reboot-lock?ref_type=heads > > It does seem to be designed to hold the lock so long as systemd indicates that > a reboot is scheduled.
Thanks. So it's a mystery for now. -- Sean Whitton
signature.asc
Description: PGP signature
