Hi Łukasz, Łukasz Stelmach <[email protected]> writes:
> Xiyue Deng <[email protected]> writes: > >> Hi Łukasz, >> >> Xiyue Deng <[email protected]> writes: >> >>> [...] >>> >>>>> I prepared a fix to check for a valid email in those envvars and fail >>>>> early if cannot find one. It should appear in experimental soon. Please >>>>> help test. >>>> >>>> I will. >>> >> >> Just want to check whether you have tried the version in experimental? >> If things are looking OK, I'll upload to unstable later this week. > > It looks better than before. The failure isn't silent, that's good, but > upon error users are left with a new unsent email buffer, which isn't > fatal, but doesn't look good either. > > Next, maybe just as a side not, I took a closer lookd at debian-bug.el > and found debian-bug-From-address variable which could be used in > reportbug-cmd to explicitly set user's email. The problem is it can > contain an adress report bug would consider invalid and fail silently > anyway. > Thanks for testing. Yes, debian-bug-From-address is used to fill-in the email address of a user, which also takes the 3 envvars (DEBEMAIL, REPORTBUGEMAIL, and EMAIL) into account. Also, after the email template is constructed, the rest, like actual sending the email for bug report, is handled by Emacs along; reportbug will not be used any more. But yes, an invalid email address would still cause trouble anyway, but that's for the user to fix. > IMHO the current code, while not ideal, doesn't leave users in the dark > and that is good. Thanks. IMHO we can consider this issue fixed (though not perfectly). I'll upload it to unstable later. -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
