Source: apt-cacher-ng Version: 3.7.5-1.1 Usertags: pidof-without-procps Dear maintainer(s) of apt-cacher-ng,
it appears that apt-cacher-ng uses `pidof` in its testsuite, or that at least one of its binary packages uses `pidof` at runtime. Historically, `pidof` was provided by the Essential package `sysvinit-tools`, making an explicit dependency unnecessary. However `pidof` will soon be moved to `procps` and will no longer be part of the Essential set. Please add an explicit dependency on `procps`: * via the `Depends:` field of all binary packages of apt-cacher-ng that use `pidof` at runtime; * via the `Build-Depends:` field of apt-cacher-ng, if `pidof` is used in tests run at build-time; * via the `Depends:` field of `debian/control/tests`, if `pidof` is used in autopkgtests. To prevent any disruption for users of apt-cacher-ng, please add this dependency now, before `pidof` is moved from `sysvinit-utils` to `procps`. Alternatively, you could remove all uses of `pidof`. It is believed that apt-cacher-ng uses `pidof` due to the following code snippets: ``` path: apt-cacher-ng_3.7.5-1.1/tests/cmdline/apt-cacher-ng.sh $exe foreground=0 logdir=$TMP CacheDir:$TMP port:$PORT pidfile=$TMP/x.pid sleep 1 pidsAfter=$(pidof apt-cacher-ng) test $(echo $pidsAfter | wc -w) -eq $(( $(echo $pidsBefore | wc -w) + 1 )) for x in $pidsAfter ; do path: apt-cacher-ng_3.7.5-1.1/tests/cmdline/apt-cacher-ng.sh pidsBefore=$(pidof apt-cacher-ng) $exe foreground=0 logdir=$TMP CacheDir:$TMP port:$PORT pidfile=$TMP/x.pid sleep 1 ``` Feel free to close this issue if this is a false positive (for example if this code is in an unreachable code path). Regards, -- Gioele Barabucci
