Source: api-sanity-checker
Version: 1.98.7-2.2
Usertags: pidof-without-procps
Dear maintainer(s) of api-sanity-checker,
it appears that api-sanity-checker uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of api-sanity-checker
that use `pidof` at runtime;
* via the `Build-Depends:` field of api-sanity-checker, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of api-sanity-checker, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that api-sanity-checker uses `pidof` due to the following
code snippets:
```
path: api-sanity-checker_1.98.7-2.2/api-sanity-checker.pl
if($_[0]==1)
{
my $pid = `pidof Xvfb`;
chomp($pid);
if($pid) {
path: api-sanity-checker_1.98.7-2.2/api-sanity-checker.pl
my $XT_DISPLAY = detectDisplay();
my $TEST_DISPLAY = $XT_DISPLAY;
my $running = `pidof Xvfb`;
chomp($running);
if(not $running or $OSgroup!~/\A(linux|bsd)\Z/)
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
