Source: drbl
Version: 5.9.1-1
Usertags: pidof-without-procps
Dear maintainer(s) of drbl,
it appears that drbl uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of drbl
that use `pidof` at runtime;
* via the `Build-Depends:` field of drbl, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of drbl, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that drbl uses `pidof` due to the following
code snippets:
```
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
echo $msg_delimiter_star_line
# Checking the services
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -z "$pidof_dnsmasq" -a -n "$pidof_dhcpd" -a -n "$pidof_tftpd" ]; then
[ "$BOOTUP" = "color" ] && $SETCOLOR_SUCCESS
echo "Proxy DHCP mode disabled successfully!"
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
echo $msg_delimiter_star_line
# Checking the services
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -n "$pidof_dnsmasq" -a -z "$pidof_dhcpd" -a -z "$pidof_tftpd" ]; then
[ "$BOOTUP" = "color" ] && $SETCOLOR_SUCCESS
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
# Checking the services
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -z "$pidof_dnsmasq" -a -n "$pidof_dhcpd" -a -n "$pidof_tftpd" ]; then
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -n "$pidof_dnsmasq" -a -z "$pidof_dhcpd" -a -z "$pidof_tftpd" ]; then
[ "$BOOTUP" = "color" ] && $SETCOLOR_SUCCESS
echo "Proxy DHCP mode enabled successfully!"
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -z "$pidof_dnsmasq" -a -n "$pidof_dhcpd" -a -n "$pidof_tftpd" ]; then
[ "$BOOTUP" = "color" ] && $SETCOLOR_SUCCESS
path: drbl_5.8.2-1/sbin/drbl-proxy-dhcp
# Checking the services
pidof_dnsmasq="$(LC_LALL=C pidof dnsmasq)"
pidof_dhcpd="$(LC_ALL=C pidof dhcpd)"
pidof_tftpd="$(LC_ALL=C pidof in.tftpd)"
if [ -n "$pidof_dnsmasq" -a -z "$pidof_dhcpd" -a -z "$pidof_tftpd" ]; then
path: drbl_5.8.2-1/setup/files/RH/rc.sysinit.default-RH.drbl
fi
nashpid=$(pidof nash 2>/dev/null)
[ -n "$nashpid" ] && kill $nashpid >/dev/null 2>&1
unset nashpid
path: drbl_5.8.2-1/setup/files/RH/rc.sysinit.default-RH.drbl
if [ "$PROMPT" != no ]; then
while :; do
pid=$(/sbin/pidof getkey)
[ -n "$pid" ] || [ -e /var/run/getkey_done ] && break
usleep 100000
path: drbl_5.8.2-1/sbin/drbl-all-service
echo -n "Waiting for portmap to be started successfully..."
while [ -z "$to_wait" ]; do
if [ -z "$(LC_ALL=C pidof portmap)" ]; then
initctl start portmap &>/dev/null
ret=$?
path: drbl_5.8.2-1/sbin/drbl-all-service
to_wait=""
while [ -z "$to_wait" ]; do
if [ -z "$(LC_ALL=C pidof portmap)" ]; then
to_wait="no"
else
path: drbl_5.8.2-1/sbin/drbl-all-service
# Stopping rpcbind daemon....
# Starting rpcbind daemon...Already running.. <--
# root@debian:/tmp# pidof rpcbind
# root@debian:/tmp# <-- Actually it's not running.
drbl_startup_service $serv_st stop
path: drbl_5.8.2-1/setup/files/misc/start_udev.drbl
kill_udevd() {
if [ -x /sbin/pidof ]; then
pid=`/sbin/pidof -x udevd`
[ -n "$pid" ] && kill $pid
fi
path: drbl_5.8.2-1/setup/files/misc/start_udev.drbl
kill_udevd() {
if [ -x /sbin/pidof ]; then
pid=`/sbin/pidof -x udevd`
[ -n "$pid" ] && kill $pid
path: drbl_5.8.2-1/setup/files/misc/drblthincli
default_dm="$(drbl-check-dm)"
(cd /etc/rc2.d; ln -fs /etc/init.d/${default_dm} S99${default_dm})
PID_X="$(pidof X)"
for ipid in $PID_X; do
kill -9 $ipid
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
