Source: fadecut
Version: 0.2.1-2
Usertags: pidof-without-procps
Dear maintainer(s) of fadecut,
it appears that fadecut uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of fadecut
that use `pidof` at runtime;
* via the `Build-Depends:` field of fadecut, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of fadecut, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that fadecut uses `pidof` due to the following
code snippets:
```
path: fadecut_0.2.1-1.1/fadecut
rhythmbox-client --enqueue "$OUTPUTDIR"/"$Fdst"
fi
if [ "$(pidof vlc)" ];
then
# enqueue to vlc player if in one instance mode (default disabled)
path: fadecut_0.2.1-1.1/fadecut
fi
TmpPid=$(pidof streamripper)
if [ -z "$TmpPid" ]; then return 0
path: fadecut_0.2.1-1.1/fadecut
kill $PidStreamripper
sleep 1
if [[ " $(pidof streamripper) " == *" $PidStreamripper "* ]];
then
logging -w "Streamripper still here, killing it!"
path: fadecut_0.2.1-1.1/fadecut
if [ $ENQUEUE -eq "1" ]; then
if [ "$(pidof rhythmbox)" ];
then
logging -i "Rhythmbox is running, adding to playlist"
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
