Source: open-iscsi
Version: 2.1.11-5
Usertags: pidof-without-procps
Dear maintainer(s) of open-iscsi,
it appears that open-iscsi uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of open-iscsi
that use `pidof` at runtime;
* via the `Build-Depends:` field of open-iscsi, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of open-iscsi, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that open-iscsi uses `pidof` due to the following
code snippets:
```
path: open-iscsi_2.1.11-4/utils/iscsi_discovery.sh
{
#check if iscsid is running
pidof iscsid &>/dev/null
ret=$?
if [ $ret -ne 0 ]; then
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
